tests/integration: fix seccomp tests on big-endian architectures#5307
Conversation
|
@cyphar @kolyshkin cypr? |
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
@ricardobranco777 thanks for the PR! I'm curious if there are simpler ways to solve it. Left a comment on that :)
The hardcoded architecture list was little-endian only, causing seccomp_arch_add() to fail with -EDOM on s390x. Drop it. It's optional and libseccomp automatically adds the native architecture when the filter is created. Fixes: opencontainers#4835 Signed-off-by: Ricardo Branco <rbranco@suse.de>
|
Verification runs in openQA:
The last is not visible but it works. |
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I kicked the failing jobs again, as they are unrelated to this. Let's see if that fixes it
|
fedora-rawhide fails consistently with
which is also the case with fedora (released version). @aojea I remember you were looking into it; have you found anything? |
The "Cannot find" message comes from the |
From "00:11:22:33:44:55" to "56:78:60:ee:6a:c3", or "4e:c3:84:5c:9d:24" ... |
7 participants
The hardcoded architecture list was little-endian only, causing seccomp_arch_add() to fail with -EDOM on s390x.
Drop it. It's optional and libseccomp automatically adds the native architecture when the filter is created.
Fixes: #4835