.travis.yml: Don't require FETCH_HEAD (partial fix for failing master tests)#1383
Merged
crosbymichael merged 1 commit intoMar 22, 2017
Conversation
wking
force-pushed
the
automatic-git-validation-commit-range
branch
2 times, most recently
from
530706f to
cb57341
Compare
Contributor
Author
|
This commit passes locally, but I expect we need vbatts/git-validation#17 to land before master builds start passing again. |
Member
|
the git-validation upstream has merged now. This PR can be reviewed. |
Member
|
Hold on this. do not review yet |
Member
|
@mrunalp ok. will you restart the travis job to check this it fixed? |
Master builds only have a 'git clone ...' [1] so FETCH_HEAD isn't defined and git-validation crashes [2]. We don't want to be hard-coding a range here, and should update git-validation to handle these cases automatically. Also echo TRAVIS_* variables during testing to make debugging git-validation easier. [1]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L243 [2]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L347 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
automatic-git-validation-commit-range
branch
from
cb57341 to
d1fb97f
Compare
Contributor
Author
|
On Tue, Mar 21, 2017 at 03:24:05PM -0700, Vincent Batts wrote:
@mrunalp ok. will you restart the travis job to check this it fixed?
I bumped the CommitDate to get a new hash and pushed cb57341 → d1fb97f
to trigger Travis. That still won't test “does the new git-validation
work for a post-merge master test?”, but I expect it will (it does for
git-validation's master test [1]). And I can always file a fixup if it
doesn't.
[1]: https://travis-ci.org/vbatts/git-validation/builds/213609902
|
Contributor
Member
|
Yes
…On Mar 21, 2017 18:53, "Mrunal Patel" ***@***.***> wrote:
@vbatts <https://github.com/vbatts> @wking <https://github.com/wking> Is
this ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1383 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6XsxwuEdtOHboA8N_SZW9LzQ1BpEks5roFTjgaJpZM4MkQPF>
.
|
Contributor
|
LGTM |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
cool. I think the failure on master https://travis-ci.org/opencontainers/runc/jobs/214004661 is something else? |
Contributor
Author
|
On Wed, Mar 22, 2017 at 02:18:48PM -0700, Vincent Batts wrote:
I think the failure on master
https://travis-ci.org/opencontainers/runc/jobs/214004661 is
something else?
Yeah. Looks like it was something about TestNotifyMemoryPressure [1].
[1]: https://travis-ci.org/opencontainers/runc/jobs/214004661#L2175
|
Member
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master builds only have a
git clone …soFETCH_HEADisn't defined and git-validation crashes. We don't want to be hard-coding a range here, and should update git-validation to handle these cases automatically.Also echo
TRAVIS_*variables during testing to make debugging git-validation easier.