Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

image: code optimization#153

Merged
zhouhao3 merged 1 commit into
opencontainers:masterfrom
zhouhao3:config-type
Jan 24, 2018
Merged

image: code optimization#153
zhouhao3 merged 1 commit into
opencontainers:masterfrom
zhouhao3:config-type

Conversation

@zhouhao3

Copy link
Copy Markdown

Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

@Mashimiao

Mashimiao commented Nov 9, 2017

Copy link
Copy Markdown

LGTM

Approved with PullApprove

@zhouhao3

zhouhao3 commented Jan 9, 2018

Copy link
Copy Markdown
Author

@coolljt0725 PTAL

@coolljt0725

Copy link
Copy Markdown
Member

why don't use v1.Image as a object?

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3

zhouhao3 commented Jan 9, 2018

Copy link
Copy Markdown
Author

This problem is discussed here, so I made the code changes. I also modified the manifest related code.

@coolljt0725

coolljt0725 commented Jan 9, 2018

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

@zhouhao3

zhouhao3 commented Jan 9, 2018

Copy link
Copy Markdown
Author

ping @Mashimiao

@zhouhao3 zhouhao3 merged commit 974de27 into opencontainers:master Jan 24, 2018
@zhouhao3 zhouhao3 deleted the config-type branch January 24, 2018 01:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants