Makefile: Add .install.esc and make it part of install.tools#540
Merged
Conversation
Contributor
|
@vbatts Does this look right? |
Member
|
lgtm, but rebase |
Contributor
Author
Contributor
|
Need to rebase after fixing master build. |
Contributor
Author
Contributor
|
👍 |
Member
|
damn. another rebase needed |
Contributor
|
🎶 keep on rebasin' 🎶 |
So we can 'make schema-fs' in Travis. Signed-off-by: W. Trevor King <wking@tremily.us>
Also consolidate the install.tools entry in the .PHONY block at the end of the Makefile. The $(var:pattern=replacement) syntax is documented in [1]. [1]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html#index-patsubst-1 Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
Author
Contributor
|
👍 |
Member
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can make
schema/fs.goin Travis.This pulls a commit out of #530, but we'll want this whether we take the #530 approach or @vbatts approach from #533. Missing this commit doesn't cause an error in the #533 tests at the moment, because the current tip is not actually rebuilting
fs.go.