Skip to content

schema: add checkPlatform#469

Closed
zhouhao3 wants to merge 1 commit into
opencontainers:masterfrom
zhouhao3:config-test
Closed

schema: add checkPlatform#469
zhouhao3 wants to merge 1 commit into
opencontainers:masterfrom
zhouhao3:config-test

Conversation

@zhouhao3

Copy link
Copy Markdown

@stevvooe

stevvooe commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@wking

wking commented Nov 22, 2016 via email

Copy link
Copy Markdown
Contributor

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3

Copy link
Copy Markdown
Author

@philips @vbatts @jonboulle @stevvooe PTAL

@jonboulle

Copy link
Copy Markdown
Contributor

These are SHOULDs, not MUSTs. Why should we validate them?
https://github.com/opencontainers/image-spec/blame/master/config.md#L63

@vbatts

vbatts commented Nov 30, 2016

Copy link
Copy Markdown
Member

i'm okay with them being checked, but not to FAIL a validation.

@wking

wking commented Dec 1, 2016 via email

Copy link
Copy Markdown
Contributor

@zhouhao3

zhouhao3 commented Dec 2, 2016

Copy link
Copy Markdown
Author

These are SHOULDs, not MUSTs. Why should we validate them?

Because these two are required attributes, and as the specification says: The name of the operating system which the image is built to run on. If it is the verification of the system, only by JSON to restrict the type is not rigorous, it should be the value of its specific judgment.

@zhouhao3

Copy link
Copy Markdown
Author

Due to my mistakes, resulting in this PR can not be updated, I will close this, and then open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants