Cfapi::updatePlaceholderState only update meta data if file is virtual - #1103
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Replacement handling can update the old destination instead of the newly converted placeholder.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request updates CFAPI placeholder metadata handling based on whether files are hydrated or virtual.
Changes:
- Propagates hydration state through the CFAPI wrapper.
- Skips metadata updates for hydrated files.
- Updates placeholder handles during conversion.
File summaries
| File | Summary |
|---|---|
src/plugins/vfs/cfapi/vfs_cfapi.cpp |
Passes hydration state based on item type. |
src/plugins/vfs/cfapi/cfapiwrapper.h |
Updates the placeholder API signature. |
src/plugins/vfs/cfapi/cfapiwrapper.cpp |
Conditionally applies metadata and placeholder updates. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dragotin
requested changes
Sep 15, 2026
| } | ||
| return updatePlaceholderState(path, modtime, size, fileId, replacesPath); | ||
| // we are converting an existing file, so it must be hydrated | ||
| return updatePlaceholderState(path, modtime, size, fileId, replacesPath, true); |
Member
There was a problem hiding this comment.
I don't get why this isHydrated is always true. The file object was just converted to placeholder which is not hydrated?
TheOneRing
force-pushed
the
work/meta
branch
from
September 15, 2026 13:26
93cf367 to
d610b3a
Compare
dragotin
approved these changes
Sep 15, 2026
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.