docs: propose guest foreground work and restart notices - #74
vincentkoc wants to merge 4 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 23, 2026, 12:23 AM ET / 04:23 UTC (Revision 3). ClawSweeper reviewWhat this changesAdds an RFC proposing bounded guest turns, persistent restart-interruption notices, fresh authorization to continue, and owner-controlled cleanup of retained sandbox allocations. Merge readiness⛔ Blocked before merge - 2 items remain Keep open for maintainer discussion and acceptance. This is a coherent, distinct draft proposal with no blocking document defects found; current main does not contain it, and the related durable-work proposals do not supersede it. Priority: P3 Review scores
Verification
How this fits togetherThe proposed Gateway policy sits between authenticated guest requests and model or tool execution. Session and transcript records preserve interrupted-turn outcomes, while sandbox allocation records keep cleanup separate from permission to resume work. flowchart TD
A[Guest request] --> B[Current authorization]
B --> C[Bounded foreground turn]
C --> D[Session and allocation records]
E[Gateway restart] --> F[Stop recovery]
D --> F
F --> G[Persistent interruption notice]
D --> H[Owner confirms shutdown before cleanup]
Decision needed
Why: This selects guest capabilities and operational tradeoffs; the repository requires explicit discussion and acceptance before the RFC can merge. Before merge
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Adopt a bounded guest lifecycle with explicit interruption outcomes and conservative cleanup, while retaining runtime containment and upgrade qualification as implementation gates. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes future behavior and does not claim to fix an executable defect in this repository. Is this the best way to solve the issue? Yes as a design proposal: it reuses named lifecycle and storage owners, separates terminal outcomes from physical shutdown, and makes rollback limitations explicit; product acceptance remains a human decision. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
|
@clawsweeper re-review Please review exact head 0e44342. The RFC remains draft pending maintainer discussion and acceptance. |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
What Problem This Solves
Guest users need a clear outcome when a Gateway restart interrupts their work. Automatically resuming that work requires authority and recovery machinery that the first guest experience does not need.
Why This Change Was Made
Propose bounded foreground guest turns, a persistent stopped-after-restart notice, and a fresh authorized request to continue in the same thread. Reuse existing session, transcript, and sandbox registry SQLite payloads: no new table, column, database, sidecar, or schema-version bump. The allocation marker
retirementPolicy: 'foreground-owner'keeps cleanup with its original owner until whole-process shutdown is confirmed.User Impact
This is a design proposal only. History remains available, interrupted guest work never resumes automatically, and staff behavior stays unchanged. Durable jobs and unqualified detached execution remain outside the initial guest profile. Generic cleanup retains marked or uncertain allocations. Older builds can ignore both markers, so incompatible downgrades require quiescing and reconciliation under compatible code first. Schema compatibility alone does not make rollback safe. Runtime containment and engine qualification remain implementation requirements.
Related proposals: #70 and #71.
Evidence
The required maintainer-discussion thread is pending. This RFC remains draft and unmerged, with no implementation issue until acceptance.