docs: make PR descriptions plain-language first - #72
roboclaw-bot wants to merge 1 commit into
Conversation
Co-authored-by: hannesrudolph <49103247+hannesrudolph@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 15, 2026, 1:06 PM ET / 17:06 UTC (Revision 2). ClawSweeper reviewWhat this changesUpdates the PR description template to put plain-language outcomes before technical rationale while keeping risks and evidence summaries visible. Merge readiness✅ Ready for maintainer review This remains a useful, focused change absent from current main. The added authoring transcript resolves the previous proof concern, and no actionable patch defects were found. Priority: P3 Review scores
Verification
How this fits togetherThis repository holds OpenClaw design proposals. Its GitHub PR template guides contributors in describing proposed changes and gives reviewers a consistent problem, impact, rationale, and evidence structure. flowchart LR
A[Contributor opens PR] --> B[PR description template]
B --> C[Problem and user impact]
B --> D[Rationale and evidence]
C --> E[Completed PR description]
D --> E
E --> F[Reviewer assessment]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Use the revised template to encourage concise descriptions while retaining visible material risks, required actions, and validation summaries. Do we have a high-confidence way to reproduce the issue? Not applicable: this changes contributor guidance rather than fixing a runtime bug; the supplied transcript demonstrates use of the revised template. Is this the best way to solve the issue? Yes: editing the existing template is a narrow, maintainable way to improve description structure without adding competing guidance or changing the RFC lifecycle. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
What Problem This Solves
PR authors need clearer guidance to explain the problem and outcome without a long technical introduction.
User Impact
Contributors are prompted to put the concrete outcome first and keep risks, migrations, required actions, and useful evidence visible. No product behavior, security boundary, compatibility, migration, or required operator action changes.
Why This Change Was Made
Carries over the approved wording from openclaw/openclaw#146253 while preserving the existing section names and maintainer-edit requirement. Hannes Rudolph (@hannesrudolph) is credited as co-author in the unchanged commit. This changes the GitHub PR description template, not an RFC proposal or its acceptance lifecycle.
Evidence
git diff --checksuccessfully.6413529432f3d7e1f96439dce158d71e273bb039. Passing workflow checks are not authoring proof and do not establish merge readiness.Observed GitHub authoring proof — September 15, 2026: used the exact HEAD template to author this existing PR via GitHub CLI 2.100.0, preserving every original template comment and heading. Live identity was verified as
roboclaw-botbefore the edit. GitHub saved the completed description; authoritative readback matched the submitted body byte-for-byte and retained the exact head/state. This is observed explicit-template authoring and save/readback proof, not browser-composer or automatic default-branch prefill proof. No runtime fix is claimed.Observed-use transcript (temporary filenames normalized)
The exact HEAD template has no checkbox checklist. Its original author-facing HTML comment, including the “Allow edits from maintainers” requirement, is retained verbatim rather than inventing checklist items.