Repository navigation
fix: avoid SQLite variable limit in thread lookups - #255
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large
neighbors --limitrequests fail while hydrating results becauseThreadsByIDsbinds one SQL parameter per ID plus the repository. More than 32,765 result IDs exceed the bundled SQLite limit.Pass the IDs through one JSON array parameter using SQLite's existing
json_eachsupport. This preserves repository scoping, duplicate and missing-ID behavior, and result ordering in callers, and also fixes the shared lookup used by search and cluster views. No schema or CLI changes are needed.The regression reproduces the previous
too many SQL variableserror with 32,768 IDs and now passes, including duplicate IDs, missing IDs, and an ID from another repository. Updated the neighbor documentation and Unreleased changelog. Thanks @masatohoshino for reporting this in #238.This fixes the SQL-limit portion of #238. The proposed temporal filters and metadata in #239 remain open under their existing product-decision hold.
Validation: focused store regression tests; full
make checkon AWS Crabbox; independent Codex review through P3 with no findings. PR CI covers Linux, macOS, Windows, and documentation.