Repository navigation
fix: compare analytics retry deadlines with fractional precision - #254
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analytics recovery can skip already-due retries when their timestamps have different fractional-second precision:
.348Zsorts after.348723Zas text. This caused the macOS release CI cancellation fixture to exit before its cancellation trigger, and can briefly defer real recovery work.Normalize the read deadline to UTC and remove the trailing UTC marker for exact fractional comparisons. Keep an indexed upper bound on the original timestamp column, so the fix preserves the existing lookup path. Apply the correction to both retry readers without changing stored data or retry/backoff policy.
Validation: deterministic regression cases passed for shorter fractions, exact equality, future work, whole seconds, and equivalent offset inputs; existing retry/backoff checks passed; all seven recovery/cancellation scenarios passed 100 repetitions; SQLite EXPLAIN confirms the covering retry index is used; independent Codex P0–P3 autoreview passed. All existing changelog bullets remain, with one added fix entry for 0.15.2.