chore(deps): update deploy-pages action to 5.0.1 - #13
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed September 4, 2026, 4:33 AM ET / 08:33 UTC. ClawSweeper reviewWhat this changesUpdates the action that publishes Swabble’s documentation to an immutable deploy-pages 5.0.1 commit and records the update in the changelog. Merge readiness✅ Ready for maintainer review The update remains useful because current main still pins 5.0.0. No actionable introduced defect was found, and the collaborator’s follow-up addresses the earlier upstream-verification concern. Priority: P3 Review scores
Verification
How this fits togetherSwabble’s Pages workflow builds the public documentation, uploads the generated site, and deploys it through GitHub Pages. The updated action submits the deployment and polls its status. flowchart LR
A[Documentation changes or manual run] --> B[Build documentation site]
B --> C[Upload site artifact]
C --> D[Pinned Pages deployment action]
D --> E[Poll deployment status]
E --> F[Published site or failure result]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Keep the existing Pages workflow and adopt the compatible upstream patch through its immutable commit pin. Do we have a high-confidence way to reproduce the issue? Not applicable: this is dependency maintenance, and no Swabble failure is claimed or reproduced. Is this the best way to solve the issue? Yes: replacing the existing immutable pin is the narrowest integration, and the collaborator explicitly verified upstream default-input compatibility. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 0268bbfd8a9d. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
Independently verified the upstream dependency to address the review's network-access limitation. Both the official GitHub tag API and Sources: official release, tag reference, complete upstream diff. Reviewed both Final-head CI and all CodeQL analyses passed at |
Integrate the landed hook cancellation cleanup from #12 while retaining the reviewed Pages action pin and changelog entry. Combined Swift tests, docs checks, release CLI/library proof, and full P0-P2 review pass.
Update the immutable
actions/deploy-pagespin from 5.0.0 to 5.0.1. This patch release adds bounded backoff and jitter to deployment-status polling and validates the polling interval; our existing default inputs remain supported. The action runtime, permissions, and deployment triggers are unchanged.The upstream release tag resolves to
368f82528645a54fb793d4d04e342629a3f51346. Reviewed the source and bundled runtime diff against 5.0.0. All other package, formatting, and Action release pins are current; Node 26 and the Swift 6.2/macOS 26 minimums remain in place.Validation: Pages workflow lint, both docs-builder regression tests, and a full local docs-site build. No Pages deployment was triggered during this preparation.
Upstream: https://github.com/actions/deploy-pages/releases/tag/v5.0.1