refactor: move activity description escaping to templates#762
Open
anonymoususer72041 wants to merge 1 commit intoopencats:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves activity description escaping for activity schedule event modals from the controller layer to the template output layer.
Previously, the contact and candidate activity modal descriptions were escaped before being assigned to the template, while the corresponding templates rendered the assigned value directly. This worked, but mixed presentation escaping into the controller flow and made it easier to accidentally introduce inconsistent escaping behavior.
The controllers now assign the raw activity note to
activityDescription, and the modal templates escape the value at the output boundary using the existing OpenCATS template escaping helper. This keeps the value escaped exactly once, avoids double escaping and aligns the contact and candidate activity schedule event modals with the preferred template output pattern.The change is intentionally limited to the contact and candidate activity schedule event modal description flow. It does not change activity creation, request handling, database handling, calendar event behavior or modal behavior.