refactor: migrate bundled lib dependencies to Composer#755
Open
anonymoususer72041 wants to merge 4 commits intoopencats:masterfrom
Open
refactor: migrate bundled lib dependencies to Composer#755anonymoususer72041 wants to merge 4 commits intoopencats:masterfrom
anonymoususer72041 wants to merge 4 commits intoopencats:masterfrom
Conversation
RussH
requested changes
May 1, 2026
Member
RussH
left a comment
There was a problem hiding this comment.
Good cleanup direction here — replacing the old FPDF/Sphinx files with Composer-managed dependencies makes sense, and removing FPDF code is food - going towards PHP 8.x.
A few things I think need fixing before merge:
- setasign/fpdf now requires ext-gd and ext-zlib, so we need to confirm/update the PHP/CI environment so composer install does not fail where GD is missing.
- ReportsUI.php no longer explicitly includes FPDF. That is fine only if vendor/autoload.php is guaranteed to be loaded globally before generateJobOrderReportPDF() runs; otherwise this will fatal with Class 'FPDF' not found.
- config/sphinx/sphinx.conf now hard-codes /usr/local/www/catsone.com/data/config/sphinx/STOPWORDS, which makes the config non-portable for normal installs/dev/CI. This probably needs to be changed, documented, or left as a path the installer/admin updates.
Can you take a look and see what clean-up can be done merging?
Contributor
Author
I will push a tiny fix for that. I wonder how we want to deal with legacy travis CI? Is there any specific reason why travis is still in this repo, @RussH?
I mixed this up with another unpublished branch of mine where I change OpenCATS to PSR-4. I will fix this also in this PR. |
d303a7b to
d795dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces bundled third-party libraries under
lib/with Composer-managed dependencies where this could be done without broader functional changes.The bundled FPDF copy was replaced with
setasign/fpdfand the bundled Sphinx PHP API was replaced withneutron/sphinxsearch-api. Related runtime includes and paths were updated accordingly.lib/artichowis intentionally not part of this migration. It is still actively used by the current graph generation code and does not have a straightforward Composer-based replacement in this context.The Sphinx client package used here is unmaintained, so this should be understood as a dependency management improvement, not as a long-term modernization of the Sphinx integration.