security: add missing authorization checks to AJAX endpoints and module actions#724
Open
anonymoususer72041 wants to merge 2 commits intoopencats:masterfrom
Open
Conversation
anonymoususer72041
added
the
security
Member
|
Sorry - just checked this, happy with this one being merged as-is. Please let me know - I see you marked it back into draft. |
Contributor
Author
I was wondering about the failing tests – just saw it now. But sure, I can revert it back "ready for review" if this is just a bug. Please let me know. |
anonymoususer72041
force-pushed
the
fix/authorize-ajax-and-module-actions
branch
from
bf1ae61 to
b118c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #720 by adding missing server-side authorization checks to several AJAX endpoints and module actions that previously relied on authentication without enforcing the required permissions.
The changes are intentionally minimal and stay close to the existing authorization patterns already used in the codebase. The goal is to prevent authenticated but unauthorized users from performing sensitive actions while preserving the behavior for properly authorized users.
The affected areas include activity-related AJAX actions, email settings test execution, saved list AJAX actions, import revert, report-related actions and calendar event edit/delete handling.
In the calendar module, the changes also prevent regular users from editing or deleting events they do not own.