Bugfix/154 colorstate comparison fails when comparing with null values

.github/workflows/build-and-test.yml

@@ -91,16 +91,66 @@ jobs:
           path: "**/build/reports"
 
 
-  test:
-    name: "Test"
-    timeout-minutes: 120
+  test_registry_unit:
+    name: "Test Registry Unit"
     needs: build
-    if: |
-      (github.event.pull_request.draft == false)
-      && (needs.check.outputs.testing_needed == 'true')
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout Branch"
+        uses: actions/checkout@v4
+
+      - name: "Setup Java"
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 21
+          cache: 'gradle'
 
+      - name: Setup Gradle cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.gradle
+          key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
+
+      - name: "Prepare libs for tests"
+        run: ./prepare.sh
+
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.registry.unit.test:check
+
+
+  test_registry_message:
+    name: "Test Registry Message"
+    needs: build
     runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout Branch"
+        uses: actions/checkout@v4
+
+      - name: "Setup Java"
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 21
+          cache: 'gradle'
 
+      - name: Setup Gradle cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.gradle
+          key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
+
+      - name: "Prepare libs for tests"
+        run: ./prepare.sh
+
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.registry.message.test:check
+
+
+  test_registry_class:
+    name: "Test Registry Class"
+    needs: build
+    runs-on: ubuntu-latest
     steps:
       - name: "Checkout Branch"
         uses: actions/checkout@v4
@@ -118,16 +168,120 @@ jobs:
           path: ~/.gradle
           key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
 
-      - name: "prepare libs for tests"
+      - name: "Prepare libs for tests"
         run: ./prepare.sh
 
-      - name: "test backend"
-        run: ./gradlew --build-cache check
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.registry.class.test:check
 
-      - name: Upload test reports
-        uses: actions/upload-artifact@v4
-        if: ${{ failure() || contains(github.event.pull_request.labels.*.name, 'force reports') }}
+
+  test_authentication:
+    name: "Test Authentication"
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout Branch"
+        uses: actions/checkout@v4
+
+      - name: "Setup Java"
+        uses: actions/setup-java@v4
         with:
-          name: Test Reports
-          path: "**/build/reports"
+          distribution: 'temurin'
+          java-version: 21
+          cache: 'gradle'
+
+      - name: Setup Gradle cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.gradle
+          key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
+
+      - name: "Prepare libs for tests"
+        run: ./prepare.sh
+
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.authentication.test:check
+
+
+  test_dal:
+    name: "Test DAL"
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout Branch"
+        uses: actions/checkout@v4
+
+      - name: "Setup Java"
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 21
+          cache: 'gradle'
+
+      - name: Setup Gradle cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.gradle
+          key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
+
+      - name: "Prepare libs for tests"
+        run: ./prepare.sh
+
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.dal.test:check
+
+
+  test_app:
+    name: "Test App"
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout Branch"
+        uses: actions/checkout@v4
+
+      - name: "Setup Java"
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 21
+          cache: 'gradle'
+
+      - name: Setup Gradle cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.gradle
+          key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
+
+      - name: "Prepare libs for tests"
+        run: ./prepare.sh
+
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.app.test:check
+
+
+  test_app_preset:
+    name: "Test App Preset"
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout Branch"
+        uses: actions/checkout@v4
+
+      - name: "Setup Java"
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 21
+          cache: 'gradle'
+
+      - name: Setup Gradle cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.gradle
+          key: ${{ runner.os }}-gradle-${{ hashFiles('versions.properties') }}-${{ github.sha }}
+
+      - name: "Prepare libs for tests"
+        run: ./prepare.sh
 
+      - name: "Run Tests"
+        run: ./gradlew --build-cache --continue --rerun-tasks :bco.app.preset:check

.github/workflows/deploy-docker.yml

@@ -16,7 +16,7 @@ on:
 
 jobs:
   docker:
-    # if: ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'preview') }}
+    if: ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'preview') }}
     runs-on: ubuntu-latest
     outputs:
       bco-tags: ${{ steps.bco-meta.outputs.tags }}

.github/workflows/update-addon-version.yaml

@@ -95,7 +95,7 @@ jobs:
           git config user.name "$GIT_USERNAME"
           git config user.email "$GIT_EMAIL"
           git add config.yaml
-          git commit -m "Update add-on $ADDONS_DIR version to $VERSION" || {
+          git commit -m "Update add-on $ADDON_DIR version to $VERSION" || {
             echo "No changes to commit"
             exit 0
           }

buildSrc/src/main/kotlin/org.openbase.bco.gradle.kts

@@ -53,7 +53,6 @@ tasks.withType<Test> {
     logging.captureStandardOutput(LogLevel.WARN)
     maxHeapSize = "7G"
     failFast = false
-    setForkEvery(1)
 }
 
 publishing {

module/app/test/src/main/java/org/openbase/app/test/agent/BCOAppTest.java

@@ -101,6 +101,9 @@ public static void tearDownBCOApp() throws Throwable {
             if (deviceManagerLauncher != null) {
                 deviceManagerLauncher.shutdown();
             }
+            if (messageManagerLauncher != null) {
+                messageManagerLauncher.shutdown();
+            }
             LOGGER.info("App tests finished!");
         } catch (Throwable ex) {
             throw ExceptionPrinter.printHistoryAndReturnThrowable(ex, LOGGER);

module/authentication/lib/src/main/java/org/openbase/bco/authentication/lib/future/AuthenticationFutureList.kt

@@ -81,4 +81,13 @@ object AuthenticationFutureList {
             notificationCondition.await()
         }
     }
+
+    fun reset() {
+        synchronized(authenticatedFuturesLock) {
+            synchronized(incomingFuturesLock) {
+                incomingFutures.clear()
+                authenticatedFutures.clear()
+            }
+        }
+    }
 }

module/authentication/test/build.gradle.kts

@@ -2,10 +2,6 @@ plugins {
     id("org.openbase.bco")
 }
 
-configurations {
-
-}
-
 dependencies {
     api(project(":bco.authentication.core"))
     api(project(":bco.authentication.lib"))

module/authentication/test/src/test/java/org/openbase/bco/authentication/test/AuthenticationFutureListTest.kt

@@ -45,6 +45,7 @@ class AuthenticationFutureListTest {
     @Timeout(5)
     @Test
     fun testScheduledTask() {
+        AuthenticationFutureList.reset()
         val lock = ReentrantLock()
         val condition: Condition = lock.newCondition()
 

module/dal/control/src/main/java/org/openbase/bco/dal/control/layer/unit/AbstractUnitController.java

@@ -157,6 +157,8 @@ public abstract class AbstractUnitController<D extends AbstractMessage & Seriali
     private final ArrayList<SchedulableAction> scheduledActionList;
     private final Timeout scheduleTimeout;
     private boolean infrastructure = false;
+    private String cachedId;
+    private String cachedLabel;
 
     public AbstractUnitController(final DB builder) throws InstantiationException {
         super(builder);
@@ -377,6 +379,10 @@ public UnitConfig applyConfigUpdate(final UnitConfig config) throws CouldNotPerf
                 logger.trace("Unit config change check failed because config is not available yet.");
             }
 
+            // clear caches
+            cachedId = null;
+            cachedLabel = null;
+
             try {
                 classDescription = getClass().getSimpleName() + "[" + config.getUnitType() + "[" + LabelProcessor.getBestMatch(config.getLabel()) + "]]";
             } catch (NullPointerException | NotAvailableException ex) {
@@ -439,6 +445,9 @@ public UnitConfig applyConfigUpdate(final UnitConfig config) throws CouldNotPerf
 
     @Override
     public final String getId() throws NotAvailableException {
+        if (cachedId != null) {
+            return cachedId;
+        }
         try {
             UnitConfig tmpConfig = getConfig();
             if (!tmpConfig.hasId()) {
@@ -449,14 +458,18 @@ public final String getId() throws NotAvailableException {
                 throw new InvalidStateException("unitconfig.id is empty");
             }
 
-            return tmpConfig.getId();
+            cachedId = tmpConfig.getId();
+            return cachedId;
         } catch (CouldNotPerformException ex) {
             throw new NotAvailableException("Unit", "id", ex);
         }
     }
 
     @Override
     public String getLabel() throws NotAvailableException {
+        if (cachedLabel != null) {
+            return cachedLabel;
+        }
         try {
             UnitConfig tmpConfig = getConfig();
             if (!tmpConfig.hasLabel()) {
@@ -466,7 +479,8 @@ public String getLabel() throws NotAvailableException {
             if (LabelProcessor.isEmpty(tmpConfig.getLabel())) {
                 throw new InvalidStateException("unitconfig.label is empty");
             }
-            return LabelProcessor.getBestMatch(getConfig().getLabel());
+            cachedLabel = LabelProcessor.getBestMatch(getConfig().getLabel());
+            return cachedLabel;
         } catch (CouldNotPerformException ex) {
             throw new NotAvailableException("Unit", "label", ex);
         }

module/dal/control/src/main/java/org/openbase/bco/dal/control/message/MessageManager.kt

@@ -41,6 +41,7 @@ class MessageManager : Launchable<Void>, VoidInitializable {
     fun removeOutdatedMessages(auth: AuthToken? = null) {
         logger.trace("removeOutdatedMessages")
         Registries.getMessageRegistry().userMessages
+            .toList()
             .filterNot { message ->
                 message.conditionList.any { condition ->
                     Units.getUnit<Message>(condition.unitId, true).let { unit ->