Fix fetchOptions dispatcher with undici v8#1894
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #1886.
Node's built-in
fetchcan pass the older undici dispatch handler shape into a user-provided dispatcher. Newerundici@8dispatchers reject that handler withUND_ERR_INVALID_ARG: invalid onRequestStart method, which breaks the documentedfetchOptions.dispatcherproxy setup.This wraps dispatcher calls with a compatibility adapter that forwards the older handler callbacks to the newer request lifecycle callbacks while leaving dispatchers that already receive the newer handler shape unchanged.
Additional context & links
Tests run:
./scripts/test tests/index.test.ts./scripts/buildundici@8.3.0ProxyAgentverifying the failure changes frominvalid onRequestStart methodto a normal proxy connection error./scripts/lint./scripts/testgit diff --check