fix(runner): persist resumed tool guardrail results - #4654
Open
FU-max-boop wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a recovery gap after resolving interrupted function-tool approvals with a client-managed Session. When an approved tool, its input and output guardrails, and its lifecycle hooks completed but the resumed Session append raised, the caller retained a
RunStatethat omitted the completed guardrail audit results. A later retry could reconcile the tool call and output through #4650, but it could not reconstruct those results without rerunning user code.RunStatebefore the fallible Session append in both runner paths.Test plan
.agents/skills/code-change-verification/scripts/run.shon the final commit and currentmain; formatting, lint, typecheck, and the full test suite all passed.Issue number
Closes #4646
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR