Skip to content

fix: preserve serialized approval resume ownership - #4613

Merged
seratch merged 1 commit into
mainfrom
fix/serialized-approval-guardrail-resume
Aug 24, 2026
Merged

fix: preserve serialized approval resume ownership#4613
seratch merged 1 commit into
mainfrom
fix/serialized-approval-guardrail-resume

Conversation

@seratch

@seratch seratch commented Aug 24, 2026

Copy link
Copy Markdown
Member

This pull request fixes serialized later-turn approval resumes when output guardrails are configured.

It records schema 1.17 current-response ownership from live item identity, validates and restores both processed and interruption identities across repeated storage hops, and keeps schema 1.16 or inconsistent checkpoints fail-closed before approved tool execution. It also adds streaming, non-streaming, session, repeated-round-trip, and adversarial coverage.

This pull request resolves #4611.

@seratch seratch added this to the 0.22.x milestone Aug 24, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-24T02:10:53.564932Z 92b3fb0 New commits
🔒 Security Review Completed 2026-08-24T02:09:42.762890Z 92b3fb0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1538b505a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/run_state.py Outdated
@seratch
seratch force-pushed the fix/serialized-approval-guardrail-resume branch from 1538b50 to 0a5e88a Compare August 24, 2026 01:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a5e88a0d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/run_state.py
@seratch
seratch force-pushed the fix/serialized-approval-guardrail-resume branch from 0a5e88a to f398252 Compare August 24, 2026 01:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f39825226e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/run_state.py Outdated
@seratch
seratch force-pushed the fix/serialized-approval-guardrail-resume branch from f398252 to 92b3fb0 Compare August 24, 2026 02:07
@seratch
seratch merged commit b354ef0 into main Aug 24, 2026
17 checks passed
@seratch
seratch deleted the fix/serialized-approval-guardrail-resume branch August 24, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialized approval checkpoints cannot be resumed with output guardrails when the interruption follows an earlier model response

1 participant