fix(realtime): preserve item status on retrieved conversation items

[shoutoutuoadi325]

Summary

conversation_item_to_realtime_message_item hardcoded status: "in_progress", discarding the status carried by the server item. When the SDK retrieves the last assistant audio item after conversation.item.input_audio_transcription.completed (or conversation.item.truncated), the server replies conversation.item.retrieved with the item's real status, usually completed. The conversion rewrote that to in_progress, and the session history merge keeps the incoming status, so a completed history entry regressed to in_progress after every user turn, with nothing to restore it.

The conversion now passes item.status through and falls back to in_progress when the server omits it, so streaming conversation.item.created events that carry no status behave exactly as before.

Test plan

• uv run pytest tests/realtime/test_item_parsing.py (status preserved; fallback to in_progress when absent)
• uv run pytest tests/realtime/test_openai_realtime.py::TestEventHandlingRobustness::test_retrieved_completed_item_keeps_status (audio delta → transcription completed triggers the retrieve → retrieved item keeps completed)
• Both new tests fail on unpatched main and pass with the fix
• uv run pytest tests/realtime/ (518 passed)
• .agents/skills/code-change-verification/scripts/run.sh (format, lint, typecheck, full test suite)

Issue number

Fixes #4597

Checks

• I've added new tests, if relevant
• I've run .agents/skills/code-change-verification/scripts/run.sh
• I've confirmed all verification steps pass
• If using Codex, I've run /review before submitting this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[leadingproblemsolver]

The converter fix looks right, but I think the regression test still stops one boundary too early. test_retrieved_completed_item_keeps_status asserts the emitted RealtimeModelItemUpdatedEvent; it never feeds that event through RealtimeSession, which is where the existing history item is actually reconciled/replaced.

That means this test could stay green while a later merge-path regression still turns a known terminal item into in_progress or drops content evidence.

I’d add one session-level fixture with an existing assistant history item (status="completed", transcript present), then process a retrieved update and assert the final session._history item preserves both lifecycle state and transcript. Parameterizing completed / incomplete would cover both terminal statuses.

There is one subtle edge worth making intentional too: item.status or "in_progress" is safe for create-like events with no status, but ConversationItem.status is optional. If a retrieved item ever arrives with status=None, this fallback can still regress an already-known terminal history item. Either assert the protocol guarantees status on retrieve, or make the session reconciliation monotonic when incoming status is absent.

Stronger contract: a refresh may add information, but it should not erase already-known terminal lifecycle state unless the protocol explicitly reports a new state.

[seratch]

Thanks for the focused fix. The production change correctly preserves an explicit server status while retaining the released missing-status fallback.

Before merge, please extend the regression coverage through RealtimeSession: attach a session listener, seed its history with a completed assistant item containing a transcript, feed a conversation.item.retrieved event that reports completed while omitting the transcript, and assert that the final history item retains both status="completed" and the existing transcript. The current test stops at RealtimeModelItemUpdatedEvent, so it does not lock down the user-visible history outcome reported in #4597.

Please keep the current item.status or "in_progress" behavior. Changing omitted-status semantics or adding a new monotonic session-state rule would widen this fix beyond the demonstrated case.

[shoutoutuoadi325]

Thanks @seratch! I've added the requested session-level coverage in tests/realtime/test_openai_realtime.py (test_retrieved_completed_item_keeps_status_in_session_history): it attaches a RealtimeSession listener to the real OpenAIRealtimeWebSocketModel, seeds its history with a completed assistant item containing a transcript, feeds a raw conversation.item.retrieved event that reports status="completed" while omitting the transcript, and asserts the final history item retains both status="completed" and the existing transcript.

I also verified the new test fails against the pre-fix converter ('in_progress' != 'completed'), so it locks down the #4597 outcome end to end. The item.status or "in_progress" behavior is unchanged, and I've intentionally not added any monotonic session-state rule.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-25T02:59:28.431284Z	b748909	New commits
🔒 Security Review	✅ Completed 2026-08-25T03:01:48.054312Z	b748909	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.