feat: add safety identifiers to scans - #609
Open
ianw-oai wants to merge 2 commits into
Open
Conversation
ianw-oai
marked this pull request as ready for review
August 22, 2026 00:19
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applications that serve multiple users need each scan's model requests to carry the originating user's safety identifier. The SDK and CLI have no per-scan option, and a value in shared configuration cannot safely distinguish concurrent users.
Changes
Add optional
ScanOptions.safetyIdentifierandcodex-security scan --safety-identifier ID. Accept a nonblank identifier of 1–64 characters with no NUL. Require API-key authentication. Omitting the option keeps ordinary scans unchanged.Copy the identifier into each scan's process environment and forward it to nested workers. Keep it on scan comparisons and automatic patch tasks. Do not change
process.envor save the identifier in shared configuration or scan recipes. Add regression tests and setup instructions.Testing
pnpm run test --seed 12345andpnpm run test: each passed 1,556 tests, with 30 platform skips and no failures.pnpm run typesandpnpm run format: passed.pnpm pack --pack-destination ../../distandpnpm run check:package ../../dist/openai-codex-security-0.1.16.tgz: passed, including installed imports, types, CLI startup, and a nested worker without a global Codex install.Risk and rollout
Requires native Codex safety identifier support. The currently bundled runtime does not support this option. Use
CODEX_CLI_PATHwith a compatible build until the native change is released and the bundled version is updated.The plugin must also forward
CODEX_SAFETY_IDENTIFIER. The SDK does not check runtime or plugin compatibility. Older versions may omit the identifier. Preflight checks the identifier's format only; authentication is checked when the scan starts.Public disclosure review