Skip to content

test: run MCP contract checks with Node - #573

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/mcp-contract-node
Aug 20, 2026
Merged

test: run MCP contract checks with Node#573
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/mcp-contract-node

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Run the MCP contract tests with Node, which is what the shipped plugin uses. This is the independent test-only part of #567.

Changes

The two tests now share one async helper for starting the server, sending the initialize and tools/list messages, and reading its replies. Launch errors reject the test directly. No production code changes.

Testing

From sdk/typescript, run:

bun test --timeout 30000 tests-ts/runtime.test.ts --test-name-pattern 'accepts preserved context|keeps native scan tools'

Both tests should inspect the real bundled MCP server without using credentials or making model calls.

Checks already run:

  • Runtime tests: 123 passed, with 9 platform-specific skips.
  • Type checks, formatting, and git diff --check passed.
  • Three independent Codex reviews and a separate verifier found no actionable issues.
  • The first local full-suite attempt was stopped after unchanged tests timed out on a heavily loaded machine. GitHub checks passed: 29 passed and 5 skipped. An unchanged release-workflow test passed on a failed-job-only rerun.
  • GitHub Codex review found no major issues at 7b8bae9ec0.

Risk and rollout

This can merge independently of the finding-matching work. It changes only the test launcher and keeps the existing assertions. The normal Windows CI jobs also exercise this file.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 19, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, 7b8bae9ec01e57a6bebf486dc8889d8f4e740595. This PR contains only the MCP contract-test cleanup split from #567.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 7b8bae9ec0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

The description now includes the final QA results and merge order. Please review the current head, 7b8bae9ec01e57a6bebf486dc8889d8f4e740595. The code has not changed since the earlier review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 7b8bae9ec0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai merged commit b85ab9e into main Aug 20, 2026
57 of 60 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/mcp-contract-node branch August 20, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants