Skip to content

feat(publish): check Linear access and skip recorded issues - #486

Open
mldangelo-oai wants to merge 9 commits into
mainfrom
mdangelo/codex/publication-preflight-and-retry
Open

feat(publish): check Linear access and skip recorded issues#486
mldangelo-oai wants to merge 9 commits into
mainfrom
mdangelo/codex/publication-preflight-and-retry

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

After a partial publication, rerunning publish scan recreates successes already recorded locally. Add a read-only preflight and an opt-in way to skip findings recorded for the same scan occurrence and Linear destination. The default publish behavior remains unchanged.

Changes

  • Add codex-security publish check SCAN_DIR --to linear --linear-team TEAM_ID for local history validation and optional read-only Linear access checks. The existing project, API-key, and assignee options keep their current environment-variable defaults. Without an API key, remote access is reported as not-checked; issue creation is never tested.
  • Add --skip-existing to publish scan. It defaults to false and skips only local records that match the exact scan occurrence, team, and optional project.
  • Export checkScanPublication and the skipExisting SDK option with the same behavior.
  • Read publication history without creating or migrating the database, include committed WAL records, support older schemas, and verify the completion-time manifest digest when one is available.
  • Preserve canonical scan-directory identity and cancellation through scan loading, history inspection, and both CLI flows. Keep inspection temporary files outside the completed scan.
  • Give the merged bundled plugin version 0.1.37 and verify a cached 0.1.22 bundle refreshes before the new history command is used.
  • Update help, documentation, focused tests, and installed-package smoke coverage for the public API additions.

The existing dry run previews issue content but does not validate recorded publication history or destination access. A separate read-only check avoids changing publish behavior, while the opt-in flag preserves intentional republishing and compatibility for existing callers.

Testing

Checks on 025fc60acbdd2855f4f995248d7b5552546a2c2d:

  • pnpm run types, pnpm run format, Ruff, and git diff --check: passed.
  • Focused publication matrix: 152 passed, 0 failed across 6 files.
  • Full seeded Bun suite: 1,608 passed, 30 platform skips, and 0 failed across 89 files.
  • pnpm run build, package archive checks, and installed-package smoke: passed with 255 archive entries and 111 bundled plugin files.
  • Final Deslop review: no remaining actionable findings.

Native Windows behavior remains delegated to hosted CI. Hosted checks were not awaited before moving to the next PR.

Risk and rollout

Skipping recorded issues is opt-in. Local history does not prove that a remote issue still exists, and the preflight does not recover retained handoffs or prove issue-creation permission. Concurrent publishers and unrecorded remote operations can still create duplicates. There is no schema migration or dependency change, and no live Linear issues were created during testing. The bundle identity change refreshes cached preview contents but does not publish a package or deploy anything.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Previously published commits retain contributor corporate-email metadata, and existing automated comments contain requester-only report references. They are not reproduced here, and the second attestation remains unchecked because they are already part of the public PR history.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review exact head 6b47211, especially read-only preflight behavior, exact history matching, and partial-retry accounting.

@github-actions github-actions Bot added the enhancement New feature or request label Aug 16, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 6b47211542

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6b47211542

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review The full and randomized suites are now green. Please review exact head 6b47211.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6b47211542

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b47211542

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/src/publish.ts Outdated
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review exact head 4aa50c1. The history-inspection cancellation feedback is fixed additively. Focused publication tests, types, formatting, and fresh installed-package smoke pass; full-suite verification is running.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 4aa50c13af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 4aa50c13af

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 16, 2026 09:43
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review The validation record is complete and the PR is ready. Please review exact head 4aa50c1. Full and randomized suites each passed 1,314 tests, the installed-package smoke passed, and all current-head GitHub checks are green.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 4aa50c13af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 4aa50c13af

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

zcrab-oai
zcrab-oai previously approved these changes Aug 16, 2026

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed read-only publication checks, resumable destination identity, cancellation, and partial recovery.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head 2ad70d4f163da7dba358f192bb71347be2b3ad60 after the main-branch reconciliation and publication-preflight updates.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 2ad70d4f16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2ad70d4f16

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai mldangelo-oai changed the title feat: check and resume Linear publication feat(publish): check Linear access and skip recorded issues Aug 22, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review exact head 025fc60acbdd2855f4f995248d7b5552546a2c2d. Focus on read-only publication-history inspection, exact scan/team/project matching, opt-in skip behavior, canonical paths and cancellation, Linear assignee access, and the cached bundle refresh from 0.1.22 to 0.1.37.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

Please review exact head 025fc60acbdd2855f4f995248d7b5552546a2c2d. Focus on read-only SQLite handling, temporary-file containment, credential and finding-data boundaries, read-only remote checks, direct team membership for private and restricted destinations, and avoiding false deduplication claims.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-22T04:22:43.626040Z 025fc60 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 025fc60acb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants