fix: resolve rescue plugin root without environment - #674
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c692458d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version: 2, | ||
| plugins: { "codex@openai-codex": [{ installPath: pluginRoot }] } | ||
| })); | ||
| const fallback = run("/bin/bash", ["-c", resumeBootstrap], { env }); |
There was a problem hiding this comment.
Invoke a portable shell in the resolver test
On native Windows, spawnSync("/bin/bash", ...) fails with ENOENT because /bin/bash is not a valid Windows executable path, so this new test fails before exercising the resolver. The repository explicitly supports Windows in tests/helpers.mjs and its runtime tests; execute the extracted Node snippet directly or resolve an available shell instead of hard-coding this Unix path.
Useful? React with 👍 / 👎.
Summary
codex:codex-rescuethrough the activecodex@openai-codexinstall registry whenCLAUDE_PLUGIN_ROOTis absentVerification
node --test tests/commands.test.mjs— 9/9 passedtask-resume-candidatereturnedavailable: falsegit diff --check— passednpm test— all 77 observed tests passed, but the existing long-runningtests/runtime.test.mjsprocess exceeded both 120 s and 300 s command limits before suite completion; no assertion failure was emittedReview
Related: LIVEROCERANO/cerbot#6004