chore(console): remove dead compose-library frontend code (studio#128) - #133
Merged
Merged
Conversation
compose.ts (Library/BundlePreview types, libraryNames, renderPreviewHtml) had exactly one caller left in the console — the New Fleet wizard's old Template/Overlay Step 2, replaced entirely in the vendor+chat-platform+ACP rewrite. Nothing else in the console imports it anymore (confirmed: only its own test file did). Removing both. Scoped to the frontend only — studio_compose::compose_named/Bundle (Rust) and the deploy_provision/compose_library_get/compose_library_set/ compose_preview MCP tools are untouched: they're still the live path for provision_from_library/provision_from_library_k8s (the compose-library provisioning flow itself still exists and works, the wizard just doesn't route through it anymore), and removing a still-registered, still-working MCP tool is a bigger call than cleaning up now-dead console code — not made here. Verification: npm run typecheck clean, npm test 100/100 passing (106 - compose.test.ts's 6), npm run build succeeds, bundle size unchanged (already tree-shaken, this is a source-hygiene cleanup not a size win). Ref #128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item 6 of #128's runbook. Discovered while scoping this: there was never a separate "Edit config" screen for the compose library specifically — the "Edit config" action on the Fleets screen edits
fleets.toml(the fleet-binding config), a different thing entirely. The compose library (Template/Overlay) was only ever reachable through the New Fleet wizard's old Step 2, which #132 already fully replaced. So this item turned out to be code cleanup, not a UI screen to remove.Change
Removed
console/src/compose.ts(Library/BundlePreviewtypes,libraryNames,renderPreviewHtml) and its test file — confirmed viagrepthat nothing in the console imports it anymore after #132.Deliberately not touched:
studio_compose::compose_named/Bundle(Rust) and thedeploy_provision/compose_library_get/compose_library_set/compose_previewMCP tools. These are still the live path forprovision_from_library/provision_from_library_k8s— the compose-library provisioning flow itself still exists and works, the wizard just doesn't route through it anymore. Removing a still-registered, still-working MCP tool that some other caller could be using is a bigger, separate decision than cleaning up now-dead console code, and there's no signal the mechanism itself (as opposed to the wizard's old UI) should go away.Verification
npm run typecheckclean,npm test100/100 passing (106 → 100, exactlycompose.test.ts's 6 tests going with it),npm run buildsucceeds.Ref #128.
🤖 Generated with Claude Code