fix asdict import - #3847
Merged
LKuemmel merged 8 commits intoAug 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes dataclass serialization on the public dataclass_utils.asdict API across configuration, device, and control code.
Changes:
- Replaces standard-library and private serializer imports.
- Adds recursive serializer type annotations.
- Adds charge-point setup exception logging.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/modules/io_devices/eebus/api.py |
Uses the public serializer import. |
packages/modules/devices/avm/avm/device.py |
Uses the public serializer import. |
packages/modules/backup_clouds/nextcloud/backup_cloud.py |
Uses the public serializer import. |
packages/helpermodules/update_config.py |
Consolidates configuration serialization imports and calls. |
packages/helpermodules/setdata.py |
Uses the custom serializer for charge-point configuration. |
packages/helpermodules/command.py |
Consolidates serialization and adds exception logging. |
packages/helpermodules/changed_values_handler.py |
Uses the public serializer import. |
packages/helpermodules/changed_values_handler_test.py |
Aligns tests with the custom serializer. |
packages/dataclass_utils/_dataclass_asdict.py |
Adds recursive result typing. |
packages/control/ev/charge_template.py |
Uses the custom serializer. |
packages/control/chargepoint/chargepoint.py |
Introduces the custom serializer import. |
packages/control/chargepoint/chargepoint_template.py |
Uses the custom serializer. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| from control.chargepoint.chargepoint_state import CHARGING_STATES, ChargepointState | ||
| from control.limiting_value import loadmanagement_limit_factory | ||
| from control.text import BidiState | ||
| from dataclass_utils import asdict |
| # Publish hierarchy to ensure the new component is recognized in the system before hierarchy check is failed | ||
| Pub().pub("openWB/set/counter/get/hierarchy", SubData.counter_all_data.data.get.hierarchy) | ||
| except (TypeError, IndexError): | ||
| log.exception("fehler beim Ladepunkt hinzufügen.") |
LKuemmel
force-pushed
the
chargemode_enums
branch
from
August 24, 2026 11:43
3a4960f to
b9e8ea3
Compare
LKuemmel
marked this pull request as ready for review
August 24, 2026 11:49
LKuemmel
force-pushed
the
feature_chargemode_enums
branch
from
August 24, 2026 11:50
3e1e495 to
bd6815f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.