MX-414: Fix deprecated methods - Reporting plugin - #549
Merged
IOhacker merged 1 commit intoSep 17, 2026
Merged
Conversation
After the Java 25 / Spring Boot 4.1 upgrade the build reports two warnings from plugin source: - BirtReadOnlyConnectionFactory: StringUtils.containsIgnoreCase is deprecated in commons-lang3 3.20; use Strings.CI.contains instead. - BirtReportingProcessServiceImpl: IEngineTask#getAppContext() returns a raw Map (BIRT's own API predates generics), causing unchecked put() warnings in setConnectionDetail; scope a @SuppressWarnings to that method since the raw type comes from a third-party API. https://mifosforge.jira.com/browse/MX-414
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks done
IOhacker
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://mifosforge.jira.com/browse/MX-414
Supersedes #548 (closed when the branch was renamed to carry the Jira key).
Summary
After the Java 25 / Spring Boot 4.1 upgrade (MX-413),
./mvnw clean packagereports two warnings from plugin source:BirtReadOnlyConnectionFactoryusesStringUtils.containsIgnoreCase, deprecated in commons-lang3 3.20 in favour ofStrings.CI.contains.BirtReportingProcessServiceImpl#setConnectionDetailcalls.put()on the rawMapreturned by BIRT'sIEngineTask#getAppContext()(a third-party API that predates generics), producing unchecked-operation warnings.Changes
StringUtils.containsIgnoreCasewithStrings.CI.containsinbeginReadOnlyTransaction.@SuppressWarnings("unchecked")tosetConnectionDetail, with a comment noting why (rawMapfrom BIRT's API, not something this plugin controls).The remaining
sun.misc.Unsafenotice in the build log comes from lombok's own internals, not from plugin source, and is out of scope here.Verification (JDK 25)
./mvnw clean compile -Dmaven.compiler.showDeprecation=true— no deprecation/unchecked warnings from plugin source./mvnw test-compile— clean./mvnw test -Dtest=BirtReadOnlyConnectionFactoryTest,BirtReportingProcessServiceImplTest— 44/44 pass./mvnw spotless:check— clean