Skip to content

MX-414: Fix deprecated methods - Reporting plugin - #549

Merged
IOhacker merged 1 commit into
openMF:developfrom
parth-sharma-10:MX-414-fix-deprecated-methods
Sep 17, 2026
Merged

IOhacker merged 1 commit into
openMF:developfrom
parth-sharma-10:MX-414-fix-deprecated-methods

Conversation

@parth-sharma-10

Copy link
Copy Markdown
Contributor

Jira: https://mifosforge.jira.com/browse/MX-414

Supersedes #548 (closed when the branch was renamed to carry the Jira key).

Summary

After the Java 25 / Spring Boot 4.1 upgrade (MX-413), ./mvnw clean package reports two warnings from plugin source:

  • BirtReadOnlyConnectionFactory uses StringUtils.containsIgnoreCase, deprecated in commons-lang3 3.20 in favour of Strings.CI.contains.
  • BirtReportingProcessServiceImpl#setConnectionDetail calls .put() on the raw Map returned by BIRT's IEngineTask#getAppContext() (a third-party API that predates generics), producing unchecked-operation warnings.

Changes

  • Replace StringUtils.containsIgnoreCase with Strings.CI.contains in beginReadOnlyTransaction.
  • Scope @SuppressWarnings("unchecked") to setConnectionDetail, with a comment noting why (raw Map from BIRT's API, not something this plugin controls).

The remaining sun.misc.Unsafe notice in the build log comes from lombok's own internals, not from plugin source, and is out of scope here.

Verification (JDK 25)

  • ./mvnw clean compile -Dmaven.compiler.showDeprecation=true — no deprecation/unchecked warnings from plugin source
  • ./mvnw test-compile — clean
  • ./mvnw test -Dtest=BirtReadOnlyConnectionFactoryTest,BirtReportingProcessServiceImplTest — 44/44 pass
  • ./mvnw spotless:check — clean

After the Java 25 / Spring Boot 4.1 upgrade the build reports two
warnings from plugin source:

- BirtReadOnlyConnectionFactory: StringUtils.containsIgnoreCase is
  deprecated in commons-lang3 3.20; use Strings.CI.contains instead.
- BirtReportingProcessServiceImpl: IEngineTask#getAppContext() returns
  a raw Map (BIRT's own API predates generics), causing unchecked
  put() warnings in setConnectionDetail; scope a @SuppressWarnings
  to that method since the raw type comes from a third-party API.

https://mifosforge.jira.com/browse/MX-414
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f0265ec8-fc10-4dff-91cc-9472aadbc096

📥 Commits

Reviewing files that changed from the base of the PR and between 2712126 and 3f5224c.

📒 Files selected for processing (2)
  • src/main/java/org/apache/fineract/infrastructure/report/service/BirtReadOnlyConnectionFactory.java
  • src/main/java/org/apache/fineract/infrastructure/report/service/BirtReportingProcessServiceImpl.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IOhacker
IOhacker merged commit af3bf20 into openMF:develop Sep 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants