Removing logback because of LGPL license - #1673
Merged
fjtirado merged 1 commit intoSep 11, 2026
Merged
Conversation
fjtirado
force-pushed
the
removing_logback
branch
from
September 11, 2026 16:16
4b9e2a5 to
65419f0
Compare
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
ricardozanini
approved these changes
Sep 11, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Replaces LGPL-licensed Logback test dependencies with the SLF4J Simple backend.
Changes:
- Removes Logback dependency management and dependencies.
- Adds test-scoped SLF4J Simple dependencies.
- Updates affected module POMs.
File summaries
| File | Description |
|---|---|
pom.xml |
Updates dependency management. |
impl/test/pom.xml |
Replaces the test logging backend. |
impl/persistence/mvstore/pom.xml |
Replaces the test logging backend. |
impl/model/pom.xml |
Replaces the test logging backend. |
api/pom.xml |
Replaces the test logging backend. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A check recently added by CNCF folks #1672 do not like logback because is LGPL, replacing it.