Skip to content

test(trace): add unit test suite for span attribute key naming and primitive value validation - #5659

Open
gcoinstash-cmd wants to merge 2 commits into
open-telemetry:mainfrom
gcoinstash-cmd:test/otel-span-attribute-sanitization
Open

gcoinstash-cmd wants to merge 2 commits into
open-telemetry:mainfrom
gcoinstash-cmd:test/otel-span-attribute-sanitization

Conversation

@gcoinstash-cmd

Copy link
Copy Markdown

Summary

Adds standalone unit tests verifying OpenTelemetry span attribute key string formatting:

  • Validates alphanumeric character hierarchy separated by dots.
  • Asserts attribute value type acceptance for primitive types (str, int, float, bool).

@gcoinstash-cmd
gcoinstash-cmd requested a review from a team as a code owner September 14, 2026 01:08
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 14, 2026

Copy link
Copy Markdown

CLA Not Signed

@opentelemetry-pr-dashboard

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-09-14 01:09 UTC

Investigate required status check failures.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

@herin049

Copy link
Copy Markdown
Contributor

I don't understand the purpose of this PR, it's not testing any behavior in the API/SDK.

@Shriprasad-P Shriprasad-P left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the change. From a first pass this looks focused; a green CI run would be the main gate from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants