Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-13 22:38 UTC Review the latest changes. Status above doesn't look right?
|
lzchen
reviewed
Sep 14, 2026
lzchen
approved these changes
Sep 14, 2026
Dotify71
force-pushed
the
fix-span-limits-docstring-typos
branch
from
September 15, 2026 02:50
e3bd17b to
d61c41f
Compare
Dotify71
force-pushed
the
fix-span-limits-docstring-typos
branch
from
September 15, 2026 16:26
4233a47 to
38106be
Compare
herin049
approved these changes
Sep 15, 2026
Shriprasad-P
left a comment
Shriprasad-P
left a comment
There was a problem hiding this comment.
Solid direction. Worth double-checking backward compatibility for existing callers of the touched API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5657
Fixes typos and grammatical errors in the
SpanLimitsclass docstring inopentelemetry-sdk:"be enforce"to"be enforced"."an a way read"to"a way to read".Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: