Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-13 22:38 UTC Review the latest changes. Status above doesn't look right?
|
Author
|
@lzchen This pr is ready for review |
herin049
approved these changes
Sep 15, 2026
herin049
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, if you have future small changes like these, please group them into a single PR.
Author
|
Thanks for the review and approval @herin049 I'll definitely group related small fixes into a single PR next time :)) |
Shriprasad-P
left a comment
There was a problem hiding this comment.
Nice focused PR. Please make sure docs/changelog stay aligned if the repo requires it for this kind of change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5655
Currently,
PeriodicExportingMetricReadervalidatesexport_interval_millisduring initialization and raises aValueErrorifexport_interval_millis <= 0. However,export_timeout_millislacked validation for values<= 0, allowing non-positive integers (0or negative values) to be passed without error.Since
_ticker()continuously callsself.collect(timeout_millis=self._export_timeout_millis), passing an unvalidated non-positive timeout causes collection timeout errors on every tick cycle.This PR adds validation for
export_timeout_millis <= 0inPeriodicExportingMetricReader.__init__().Type of change
How Has This Been Tested?
opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py(test_timeout_value_exception_on_zero,test_timeout_value_exception_on_negative).Does This PR Require a Contrib Repo Change?
Checklist: