fix(sdk): add validation for export_timeout_millis <= 0 in BatchSpanP… - #5650
Open
Dotify71 wants to merge 1 commit into
Open
fix(sdk): add validation for export_timeout_millis <= 0 in BatchSpanP…#5650Dotify71 wants to merge 1 commit into
Dotify71 wants to merge 1 commit into
Conversation
|
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-10 21:28 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5648
Currently,
BatchSpanProcessorvalidatesmax_queue_size,schedule_delay_millis, andmax_export_batch_sizeduring initialization to ensure they are positive integers. However,export_timeout_milliswas omitted from argument validation, allowing non-positive or negative values (0or negative integers) to be passed without error.This PR adds validation for
export_timeout_millisinBatchSpanProcessor._validate_arguments(), raising aValueErrorifexport_timeout_millis <= 0.Type of change
How Has This Been Tested?
opentelemetry-sdk/tests/trace/export/test_export.py(test_invalid_export_timeout_millis)Does This PR Require a Contrib Repo Change?
Checklist: