Skip to content

perf(propagator): optimize fields lookup via set union #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swayumm02-creator wants to merge 1 commit into from
+5 −7
Closed

perf(propagator): optimize fields lookup via set union #5649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions opentelemetry-api/src/opentelemetry/propagators/composite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,12 @@ def fields(self) -> set[str]:
See
`opentelemetry.propagators.textmap.TextMapPropagator.fields`
"""
composite_fields = set()

for propagator in self._propagators:
for field in propagator.fields:
composite_fields.add(field)

return composite_fields
if not self._propagators:
return set()

return set.union(
*(set(propagator.fields) for propagator in self._propagators)
)

@deprecated("You should use CompositePropagator. Deprecated since version 1.2.0.")
class CompositeHTTPPropagator(CompositePropagator):
Expand Down