Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5647.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-api`: Added guard for negative value on max_value_len
2 changes: 2 additions & 0 deletions opentelemetry-api/src/opentelemetry/attributes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ def __init__(
) -> None:
if maxlen is not None and maxlen < 0:
raise ValueError("maxlen must be valid int greater or equal to 0")
if max_value_len is not None and max_value_len < 0:
raise ValueError("max_value_len must be valid int greater or equal to 0")
self._dict: dict[str, types.AnyValue] = {}
self.maxlen = maxlen
self.dropped = 0
Expand Down
4 changes: 4 additions & 0 deletions opentelemetry-api/tests/attributes/test_attributes.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ def test_negative_maxlen_not_allowed(self):
with self.assertRaises(ValueError):
BoundedAttributes(-1)

def test_negative_max_value_len_not_allowed(self):
with self.assertRaises(ValueError):
BoundedAttributes(1, {"first": "value"}, immutable=False, max_value_len=-1)

def test_base_copy_isolated_and_len_works(self):
dic_len = len(self.base)
base_copy = self.base.copy()
Expand Down
Loading