Change declarative config pojos from with<Prop> to set<Prop> - #8742
Open
jack-berg wants to merge 1 commit into
Open
Change declarative config pojos from with<Prop> to set<Prop>#8742jack-berg wants to merge 1 commit into
jack-berg wants to merge 1 commit into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-21 22:09 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8742 +/- ##
=========================================
Coverage 91.28% 91.28%
- Complexity 10473 10474 +1
=========================================
Files 1006 1006
Lines 28277 28277
Branches 3569 3569
=========================================
+ Hits 25812 25813 +1
Misses 1674 1674
+ Partials 791 790 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8402
Currently, declarative pojos have
<PojoType> with<Prop>(<PropType> propName)methods for setting properties on mutable pojo types in a fluid manner. This is problematic, becausewith<Prop>heavily implies the the result is an immutable copy with the property changed.This PR changes to
<PojoType> set<Prop>(<PropType> propName), which I think is the best option for us:Despite the seeming large size of the PR, there is only one meaningful file changed in this PR: https://github.com/open-telemetry/opentelemetry-java/pull/8742/changes#diff-7a86335581560379612dfc344b0c7da937cec60da747e29f4873386fd9473f2f
The rest are find/replace.