Skip to content

Require explanations for suppressed warnings in logging OTLP - #8741

Open
noor-ahmadi wants to merge 1 commit into
open-telemetry:mainfrom
noor-ahmadi:require_suppression_explanations
Open

Require explanations for suppressed warnings in logging OTLP#8741
noor-ahmadi wants to merge 1 commit into
open-telemetry:mainfrom
noor-ahmadi:require_suppression_explanations

Conversation

@noor-ahmadi

Copy link
Copy Markdown

This adds a module setting for SuppressWarningsWithoutExplanation and turns it on for the logging OTLP exporter. The setting lets other modules adopt the check once their existing suppressions are explained.

Related to #7874.

Tested with ./gradlew :exporters:logging-otlp:check.

@noor-ahmadi
noor-ahmadi requested a review from a team as a code owner August 21, 2026 19:51
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 21, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: noor-ahmadi / name: Noor Ahmadi (339df62)

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-08-21 23:09 UTC

Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):

  • Top-level threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

@noor-ahmadi

Copy link
Copy Markdown
Author

Pull request dashboard status

Waiting on the author · refreshed 2026-08-21 19:54 UTC

Wait for the required status checks to report; this pull request moves to reviewers once the results are clean.

Status above doesn't look right?

fixed the CLA signing issue

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.28%. Comparing base (b421aed) to head (2f39282).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8741   +/-   ##
=========================================
  Coverage     91.28%   91.28%           
+ Complexity    10473    10472    -1     
=========================================
  Files          1006     1006           
  Lines         28277    28277           
  Branches       3569     3569           
=========================================
+ Hits          25812    25814    +2     
+ Misses         1674     1671    -3     
- Partials        791      792    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea here is to go module by module and flip the requireSuppressWarningsExplanation flag until all are updated?

If so, I'd prefer we invert:

  • set the default for requireSuppressWarningsExplanation=true
  • Update all modules excluding the first test module to requireSuppressWarningsExplanation=false
  • Add comment(s) indicating we should delete the requireSuppressWarningsExplanation property once all are migrated

@noor-ahmadi

Copy link
Copy Markdown
Author

So the idea here is to go module by module and flip the requireSuppressWarningsExplanation flag until all are updated?

If so, I'd prefer we invert:

  • set the default for requireSuppressWarningsExplanation=true
  • Update all modules excluding the first test module to requireSuppressWarningsExplanation=false
  • Add comment(s) indicating we should delete the requireSuppressWarningsExplanation property once all are migrated

Yeah thats the idea but okay gotcha, I'll look into inverting thanks!

@noor-ahmadi
noor-ahmadi force-pushed the require_suppression_explanations branch from 339df62 to 2f39282 Compare August 21, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants