Require explanations for suppressed warnings in logging OTLP - #8741
Require explanations for suppressed warnings in logging OTLP#8741noor-ahmadi wants to merge 1 commit into
Conversation
|
|
Pull request dashboard statusWaiting on the author · refreshed 2026-08-21 23:09 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
fixed the CLA signing issue |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8741 +/- ##
=========================================
Coverage 91.28% 91.28%
+ Complexity 10473 10472 -1
=========================================
Files 1006 1006
Lines 28277 28277
Branches 3569 3569
=========================================
+ Hits 25812 25814 +2
+ Misses 1674 1671 -3
- Partials 791 792 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jack-berg
left a comment
There was a problem hiding this comment.
So the idea here is to go module by module and flip the requireSuppressWarningsExplanation flag until all are updated?
If so, I'd prefer we invert:
- set the default for requireSuppressWarningsExplanation=true
- Update all modules excluding the first test module to requireSuppressWarningsExplanation=false
- Add comment(s) indicating we should delete the requireSuppressWarningsExplanation property once all are migrated
Yeah thats the idea but okay gotcha, I'll look into inverting thanks! |
339df62 to
2f39282
Compare
This adds a module setting for
SuppressWarningsWithoutExplanationand turns it on for the logging OTLP exporter. The setting lets other modules adopt the check once their existing suppressions are explained.Related to #7874.
Tested with
./gradlew :exporters:logging-otlp:check.