Wire otlp common test suites into check - #8738
Merged
jack-berg merged 1 commit intoAug 20, 2026
Merged
Conversation
thswlsqls
marked this pull request as ready for review
August 20, 2026 06:48
Pull request dashboard statusMerged · refreshed 2026-08-20 14:28 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8738 +/- ##
============================================
- Coverage 91.27% 91.26% -0.01%
+ Complexity 10471 10470 -1
============================================
Files 1006 1006
Lines 28276 28276
Branches 3568 3568
============================================
- Hits 25808 25807 -1
Misses 1675 1675
- Partials 793 794 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Aug 20, 2026
Contributor
|
Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8736
Description
exporters/otlp/common/build.gradle.ktsregisters thetestIncubatingJvmTestSuite but never wires it intocheck, so its 4 tests have not run in CI since Add experimental support for log extended attributes #7123 added the suite (2025-04-11).tasks { check { dependsOn(testing.suites) } }block thatsdk/trace,sdk/logs,contextand eight other modules already use.LogRecordDataeven when api-incubator is on the classpath.api/incubatorand named this module as the remaining one.Testing done
./gradlew :exporters:otlp:common:check --dry-runnow lists:exporters:otlp:common:testIncubating; it was absent before../gradlew :exporters:otlp:common:check— BUILD SUCCESSFUL, 122 tests passed (118 existing plus the 4 from the newly wired suite, all green).docs/apidiffs/is untouched.