Skip to content

feat: Create a GitHub action to validate test coverage/compliance with the spec for SDK repos#389

Open
JamieSinn wants to merge 1 commit into
open-feature:mainfrom
JamieSinn:repo-parser-github-action
Open

feat: Create a GitHub action to validate test coverage/compliance with the spec for SDK repos#389
JamieSinn wants to merge 1 commit into
open-feature:mainfrom
JamieSinn:repo-parser-github-action

Conversation

@JamieSinn

Copy link
Copy Markdown
Member

This PR

  • Adds a github action and docs for use in downstream SDK repos to make sure that the SDKs have adequate test coverage and appropriately flag where and how each component of the tests are validating the spec.

Related Issues

#258
This is stacked on #388 and #388 should be merged first.

Follow-up Tasks

  • Implement this in all the SDK repos that are >= 1.0 as a required test, and for all non 1.0 make this a non-required action.
  • Update existing 1.0+ descriptions where they've fallen out of date
  • Identify/create tickets for any gaps in test coverage for the spec in 1.0+ repos

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new GitHub Action for OpenFeature spec compliance checking, along with updated documentation, examples, and minor bug fixes in the Python parser. The code review highlights several critical improvements: using a stable Python 3.13 version instead of the unreleased 3.14 in the Dockerfile and Ruff configuration, conditionally replacing the inline comment prefix in spec_finder.py to avoid redundant string operations, and replacing the openssl dependency with a native bash variable for generating random delimiters in the GitHub Action to ensure compatibility across minimal runner environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tools/repo_parser/Dockerfile
Comment thread tools/repo_parser/pyproject.toml
Comment thread tools/repo_parser/spec_finder.py
Comment thread tools/repo_parser/action.yml
Comment thread .github/workflows/publish-repo-parser.yaml
Signed-off-by: Jamie Sinn <james.sinn@dynatrace.com>
@JamieSinn JamieSinn force-pushed the repo-parser-github-action branch from ac01e6f to b509762 Compare June 8, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants