-
Notifications
You must be signed in to change notification settings - Fork 80
fix: correct grace-period/max-retry-backoff defaults to prevent log spam #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
353fdb1
a17c872
64b992e
34c58ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ | |
| "events", | ||
| "contextEnrichment", | ||
| "fractional-v1", | ||
| "fractional-v3", | ||
| "deprecated" | ||
| }) | ||
| @Testcontainers | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,9 +72,9 @@ public void setupProvider(String providerType) throws InterruptedException { | |
| state.builder | ||
| .deadline(1000) | ||
| .keepAlive(0) | ||
| .retryGracePeriod(2) | ||
| .retryGracePeriod(5) | ||
| .retryBackoffMs(500) | ||
| .retryBackoffMaxMs(2000); | ||
| .retryBackoffMaxMs(500); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since i saw that on slack, should just scale the real values by a factor?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What I actually want to do in a follow-up, is get all these specific adjustments FROM gherkin. Right now they are just hard coded in the test implementation which is annoying. I don't think we'll do a scaling thing because that would be complicated or a new config - but getting it from the gherkin will be much better... I just didn't want to do that here. |
||
| boolean wait = true; | ||
|
|
||
| switch (providerType) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i'm understanding this correctly but would
notAssertedEventsbe a better name then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for "negative" assertions - ie: make sure some event X was NOT fired - so we keep an un-drained list of all of them.