feat: migrate to the connect based grpc setup - #2042
Conversation
This is a pretty near 1:1 swap of the grpc handler to align to connect. There are a few notable changes: - the setting added in #1998 are not required anymore because connect has no minimum. This on the client side is a drop in replacement; no changes there needed. Signed-off-by: Jamie Sinn <james.sinn@dynatrace.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
erka
left a comment
There was a problem hiding this comment.
great work! some small nits from me.
|
I would love if we could make |
|
Follow-up, not for this PR: we could mark Caching caveat: the selector must be in the URL (query/message) to be cache-safe, or the server sets Vary: Flagd-Selector on the response so caches key on that request header too... or it wouldn't be a cache factor. I'll open an issue to track that I think. |
Signed-off-by: Jamie Sinn <james.sinn@dynatrace.com>
|



This PR
This is a pretty near 1:1 swap of the grpc handler to align to connect.
There are a few notable changes:
This on the client side is a drop in replacement; no changes there needed.