feat: Create GlobalHookManager. - #134
Open
NeaguGeorgiana23 wants to merge 2 commits into
Open
Conversation
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Comment |
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
GlobalHookManageras an independent, thread-safe singleton to store and manage global hooks usingstd::shared_mutex.OpenFeatureAPI, mirroring the design pattern established byGlobalContextManager. This allowsClientAPIto access global hooks during flag evaluation without introducing a circular dependency between:client_apiand:openfeature_apiin Bazel.OpenFeatureAPIto delegateAddHook,AddHooks,GetHooks, andShutdown(clearing hooks) toGlobalHookManager::GetInstance().nullptrhook pointers are filtered out and registration order is strictly preserved.test/global_hook_manager_test.cppcovering initial state, single/batch hook registration, order preservation, null filtering, hook clearing, and multithreaded reader/writer stress testing.Related Issues
Fixes #133
Follow-up Tasks
before,after,error,finally) insideClientAPI::EvaluateFlag.