Skip to content

Remove OCSP-URL-ISSUER usage #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martenrebane merged 1 commit into from
May 8, 2026
Merged

Remove OCSP-URL-ISSUER usage #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/androidTest/kotlin/ee/ria/DigiDoc/viewmodel/DiagnosticsViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ class DiagnosticsViewModelTest {
tslUrl = "https://www.example.com",
tslCerts = listOf("CERT0000111122224444"),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
1 change: 0 additions & 1 deletion app/src/androidTest/kotlin/ee/ria/DigiDoc/viewmodel/MobileIdViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ class MobileIdViewModelTest {
tslUrl = "https://www.example.com",
tslCerts = listOf("CERT0000111122224444"),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
1 change: 0 additions & 1 deletion app/src/androidTest/kotlin/ee/ria/DigiDoc/viewmodel/SmartIdViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ class SmartIdViewModelTest {
tslUrl = "https://www.example.com",
tslCerts = listOf("CERT0000111122224444"),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
1 change: 0 additions & 1 deletion ...ndroidTest/kotlin/ee/ria/DigiDoc/configuration/domain/model/ConfigurationViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ class ConfigurationViewModelTest {
"tslUrl",
emptyList(),
"tsaUrl",
emptyMap(),
"ldapPersonUrl",
ldapPersonUrls = listOf("ldapPersonUrl"),
"ldapCorpUrl",
Expand Down
1 change: 0 additions & 1 deletion ...lib/src/androidTest/kotlin/ee/ria/DigiDoc/configuration/loader/ConfigurationLoaderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ class ConfigurationLoaderTest {
"eE/VmJs0niWtKlX4UURG0HAGjZIQ/pJejV+7GzknFMZmuiwJQe4yT4mw=",
),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
1 change: 0 additions & 1 deletion ...androidTest/kotlin/ee/ria/DigiDoc/configuration/repository/ConfigurationRepositoryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ class ConfigurationRepositoryTest {
"eE/VmJs0niWtKlX4UURG0HAGjZIQ/pJejV+7GzknFMZmuiwJQe4yT4mw=\n",
),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
1 change: 0 additions & 1 deletion config-lib/src/main/kotlin/ee/ria/DigiDoc/configuration/provider/ConfigurationProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ data class ConfigurationProvider(
@SerializedName("TSL-URL") val tslUrl: String,
@SerializedName("TSL-CERTS") val tslCerts: List<String>,
@SerializedName("TSA-URL") val tsaUrl: String,
@SerializedName("OCSP-URL-ISSUER") val ocspUrls: Map<String, String>,
@SerializedName("LDAP-PERSON-URL") val ldapPersonUrl: String,
@SerializedName("LDAP-PERSON-URLS") val ldapPersonUrls: List<String>,
@SerializedName("LDAP-CORP-URL") val ldapCorpUrl: String,
Expand Down
1 change: 0 additions & 1 deletion crypto-lib/src/androidTest/kotlin/ee/ria/DigiDoc/cryptolib/CryptoContainerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ class CryptoContainerTest {
tslUrl = "https://www.example.com",
tslCerts = listOf("CER00001", "CER00002"),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
1 change: 0 additions & 1 deletion ...igidoc-lib/src/androidTest/kotlin/ee/ria/DigiDoc/libdigidoclib/init/InitializationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ class InitializationTest {
tslUrl = "https://www.example.com",
tslCerts = listOf(),
tsaUrl = "https://www.example.com",
ocspUrls = mapOf("issuer" to "https://www.example.com"),
ldapPersonUrl = "https://www.example.com",
ldapPersonUrls = listOf("https://www.example.com"),
ldapCorpUrl = "https://www.example.com",
Expand Down
10 changes: 0 additions & 10 deletions libdigidoc-lib/src/main/kotlin/ee/ria/DigiDoc/libdigidoclib/init/Initialization.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ import ee.ria.DigiDoc.utilsLib.logging.LoggingUtil.Companion.debugLog
import ee.ria.DigiDoc.utilsLib.logging.LoggingUtil.Companion.errorLog
import ee.ria.libdigidocpp.Conf
import ee.ria.libdigidocpp.DigiDocConf
import ee.ria.libdigidocpp.StringMap
import ee.ria.libdigidocpp.digidoc
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers.IO
Expand Down Expand Up @@ -192,7 +191,6 @@ class Initialization
overrideTSLUrl(configurationProvider.tslUrl)
overrideTSLCert(configurationProvider.tslCerts)
overrideSivaUrl(configurationProvider.sivaUrl)
overrideOCSPUrls(configurationProvider.ocspUrls)
overrideTSCerts(configurationProvider.certBundle)
overrideTSUrl(configurationProvider.tsaUrl)
overrideVerifyServiceCert(configurationProvider.certBundle)
Expand Down Expand Up @@ -421,14 +419,6 @@ class Initialization
}
}

private fun overrideOCSPUrls(ocspUrls: Map<String, String>) {
val stringMap = StringMap()
for ((key, value) in ocspUrls) {
stringMap[key] = value
}
DigiDocConf.instance().setOCSPUrls(stringMap)
}

private fun loadConfiguration(context: Context) {
configurationRepository.getConfiguration()?.let { overrideConfiguration(context, it) }
CoroutineScope(Main).launch {
Expand Down
Loading