You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes five declared-but-unused dependencies that knip had flagged and that were parked behind // TODO: triage and remove entries in knip.jsonc. Each was verified to have no usage before removal:
Root package.json devDependencies:
changelog-parser — no source references anywhere in the repo.
infer-owner — no source references anywhere in the repo.
semver — the root declaration has no importer. The semver deps in packages/cdktn, packages/cdktn-cli, and packages/@cdktn/cli-core are genuinely used and are left in place; only the redundant root-level declaration is removed.
test/package.json devDependencies:
express and @types/express — no usage.
knip.jsonc is updated to drop the corresponding ignoreDependencies entries and their TODO comments.
Thanks for the cleanup here. One important release-path detail: release-please has not taken over the full release job yet; it only maintains the release PR / changelog / manifest in the current setup. The GitHub Release is still created by the existing release workflow, which still depends on the tool that imports changelog-parser.
Current dependency trace:
.github/workflows/release-please.yml documents that release-please runs with skip-github-release: true, so it does not create the tag or GitHub Release. Its comments say that responsibility remains with release.yml's release_github job.
.github/workflows/release.yml has the active release_github job (Release to Github) which runs pnpm run release-github.
package.json maps release-github to tools/release-github.sh.
tools/release-github.sh calls tools/extract-changelog to build the GitHub Release body.
tools/extract-changelog does require("changelog-parser").
So removing the root changelog-parser dependency breaks the currently configured GitHub Release creation path. If the goal is to retire that path because release-please should own GitHub releases too, this PR should also update the release ownership intentionally (for example, flip release-please off skip-github-release and remove/update the release_github job and the now-obsolete tools). Otherwise, changelog-parser should stay declared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes five declared-but-unused dependencies that
kniphad flagged and that were parked behind// TODO: triage and removeentries inknip.jsonc. Each was verified to have no usage before removal:package.jsondevDependencies:changelog-parser— no source references anywhere in the repo.infer-owner— no source references anywhere in the repo.semver— the root declaration has no importer. Thesemverdeps inpackages/cdktn,packages/cdktn-cli, andpackages/@cdktn/cli-coreare genuinely used and are left in place; only the redundant root-level declaration is removed.test/package.jsondevDependencies:expressand@types/express— no usage.knip.jsoncis updated to drop the correspondingignoreDependenciesentries and their TODO comments.Checklist