fix(cli): include dev dependencies in npm version lookup#280
fix(cli): include dev dependencies in npm version lookup#280sakul-learning wants to merge 2 commits into
Conversation
|
@sakul-learning Could you also validate with the repro repo using yarn instead of npm? |
|
@forivall I validated the repro against Yarn classic as well. What I tested:
Results:
So the PR fix is validated for the Yarn version-lookup repro: the One caveat: That looks like a separate Yarn/workspace behavior, not the original version-lookup bug fixed here. Also, on the CI failures: I was able to reproduce intermittent Terraform Registry failures right now, even though the HashiCorp status page reports "fully operational". The failed integration logs show Terraform timing out while querying provider download metadata, e.g.: I also hit a timeout locally against the same registry endpoint, and then it responded later. That makes the current integration failures look like Terraform Registry/service instability rather than something caused by this PR. EDIT: Confirmed Hashicorp services incident |
just curious, yarn classic is in maintenance mode and lacks quite a few supply chain attack safeguards, cdktn migrated to pnpm due to that |
Summary
cdktn/cdktfpackage version.Fixes: #278
Testing
pnpm nx test @cdktn/commons --runInBand --testFile=src/debug.test.tspnpm nx build cdktn-clicdktn debugcdktn provider listcdktn provider add random