Skip to content

feat(core): add honox framework target - #180

Open
ysknsid25 wants to merge 1 commit into
mainfrom
feat/honox-core
Open

feat(core): add honox framework target#180
ysknsid25 wants to merge 1 commit into
mainfrom
feat/honox-core

Conversation

@ysknsid25

@ysknsid25 ysknsid25 commented Aug 8, 2026

Copy link
Copy Markdown
Member

resolves: #175
Adds the hono/jsx reactivity adapter to @formisch/core and exposes it through the ./honox subpath.


Stack created with GitHub Stacks CLIGive Feedback 💬

Summary by CodeRabbit

  • New Features
    • Added Honox as a supported framework option.
    • Added a reactive runtime with signals, batched updates, dependency tracking, and untracked execution.
    • Added unique identifier generation for reactive elements.
    • Exposed the Honox package export for application use.

Copilot AI lite review requested due to automatic review settings August 8, 2026 13:07
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e666b836-b118-4493-ab76-7a0cd9945290

📥 Commits

Reviewing files that changed from the base of the PR and between 865212e and 1ee4be6.

📒 Files selected for processing (4)
  • packages/core/package.json
  • packages/core/src/framework/index.honox.ts
  • packages/core/src/framework/index.ts
  • packages/core/tsdown.config.ts

Walkthrough

Added Honox as a supported framework. Added a reactive runtime with signals, listener tracking, batched updates, and untracked callbacks. Registered Honox in the build configuration and exposed its generated JavaScript and type declaration files through the package exports.

Suggested reviewers: fabian-hiller

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The adapter meets the Honox implementation objectives, but the change modifies existing files despite issue #175 requiring an additive change without such modifications. Clarify or update issue #175 to permit the required package, framework type, and build configuration changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of the Honox framework target.
Out of Scope Changes check ✅ Passed The existing-file changes support the Honox adapter, package export, framework type, and build configuration described in the objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Honox framework target to @formisch/core by introducing a Honox-specific reactivity adapter and wiring it into the build + package exports so consumers can import it via @formisch/core/honox.

Changes:

  • Added a Honox framework adapter (index.honox.ts) implementing createSignal, batch, and untrack consistent with existing DOM-style adapters (notably React).
  • Updated framework type unions to include 'honox' so the adapter can be selected/typed consistently.
  • Updated build configuration and package exports to produce and expose dist/index.honox.* via the ./honox subpath.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/core/tsdown.config.ts Adds honox to the framework build matrix so index.honox artifacts are generated.
packages/core/src/framework/index.ts Extends the Framework union type to include 'honox'.
packages/core/src/framework/index.honox.ts New Honox adapter implementing core reactive primitives for this framework target.
packages/core/package.json Exposes @formisch/core/honox via exports pointing to the new build outputs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/core/src/framework/index.honox.ts
@ysknsid25
ysknsid25 requested a review from fabian-hiller August 9, 2026 04:49
@fabian-hiller

Copy link
Copy Markdown
Member

Thank you for working on this. I plan to review and merge it after our v1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Honox framework adapter

3 participants