feat(core): add honox framework target - #180
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughAdded Honox as a supported framework. Added a reactive runtime with signals, listener tracking, batched updates, and untracked callbacks. Registered Honox in the build configuration and exposed its generated JavaScript and type declaration files through the package exports. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new Honox framework target to @formisch/core by introducing a Honox-specific reactivity adapter and wiring it into the build + package exports so consumers can import it via @formisch/core/honox.
Changes:
- Added a Honox framework adapter (
index.honox.ts) implementingcreateSignal,batch, anduntrackconsistent with existing DOM-style adapters (notably React). - Updated framework type unions to include
'honox'so the adapter can be selected/typed consistently. - Updated build configuration and package exports to produce and expose
dist/index.honox.*via the./honoxsubpath.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/tsdown.config.ts | Adds honox to the framework build matrix so index.honox artifacts are generated. |
| packages/core/src/framework/index.ts | Extends the Framework union type to include 'honox'. |
| packages/core/src/framework/index.honox.ts | New Honox adapter implementing core reactive primitives for this framework target. |
| packages/core/package.json | Exposes @formisch/core/honox via exports pointing to the new build outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Thank you for working on this. I plan to review and merge it after our v1 release. |
resolves: #175
Adds the hono/jsx reactivity adapter to
@formisch/coreand exposes it through the./honoxsubpath.Stack created with GitHub Stacks CLI • Give Feedback 💬
Summary by CodeRabbit