Skip to content

chore: Update ESLint to v9.39.5 - #178

Open
ysknsid25 wants to merge 2 commits into
mainfrom
chore/174
Open

chore: Update ESLint to v9.39.5#178
ysknsid25 wants to merge 2 commits into
mainfrom
chore/174

Conversation

@ysknsid25

@ysknsid25 ysknsid25 commented Aug 6, 2026

Copy link
Copy Markdown
Member

resolves: #174

Summary by CodeRabbit

  • Chores
    • Upgraded the website’s linting setup to ESLint 9.
    • Added modern JavaScript, TypeScript, and Qwik linting presets.
    • Consolidated linting configuration into a flat configuration format.
    • Updated TypeScript project configuration to recognize the new lint setup.
    • Refreshed linting dependencies and project-wide environment settings.

Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Copilot AI lite review requested due to automatic review settings August 6, 2026 07:39
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb579e66-9958-43d6-9254-de069db6c7b2

📥 Commits

Reviewing files that changed from the base of the PR and between 426ad7e and 8229b80.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • website/package.json
💤 Files with no reviewable changes (1)
  • website/package.json

Walkthrough

The website migrated from ESLint 8 legacy configuration to ESLint 9 flat configuration. The new configuration includes JavaScript, TypeScript, and Qwik presets, project-wide ignores, environment globals, TypeScript project-service parsing, JSX support, and project-specific rules. The package metadata adds the required ESLint packages, removes @types/eslint, and updates ESLint. TypeScript now references eslint.config.js.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: upgrading ESLint to version 9.39.5.
Linked Issues check ✅ Passed The changes replace ESLint 8.57.1 with 9.39.5 and migrate the website configuration to ESLint 9.
Out of Scope Changes check ✅ Passed All reviewed changes support the ESLint 9 upgrade and related configuration migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the website workspace lint tooling to ESLint v9.39.5 and migrates configuration from legacy .eslintrc/.eslintignore to an ESLint flat config (eslint.config.js), aligning with ESLint v9’s recommended setup and addressing the deprecated eslint@8.57.1 warning in issue #174.

Changes:

  • Upgraded website devDependencies to ESLint ^9.39.5 and added supporting flat-config dependencies (@eslint/js, globals, typescript-eslint).
  • Replaced website/.eslintrc.cjs and website/.eslintignore with a new website/eslint.config.js flat config.
  • Updated website/tsconfig.json to include the new ESLint config file, and refreshed pnpm-lock.yaml.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
website/tsconfig.json Updates TS project files list to reference eslint.config.js instead of the removed .eslintrc.cjs.
website/package.json Bumps ESLint to v9 and adds flat-config-related devDependencies.
website/eslint.config.js Introduces ESLint v9 flat configuration with global ignores, TS + Qwik presets, and local rule overrides.
website/.eslintrc.cjs Removes legacy ESLint config (replaced by flat config).
website/.eslintignore Removes legacy ignore file (replaced by flat config ignores).
pnpm-lock.yaml Lockfile updates reflecting ESLint v9 and dependency changes.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread website/package.json

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread website/eslint.config.js
Comment thread website/eslint.config.js
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
@ysknsid25
ysknsid25 requested a review from fabian-hiller August 6, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WARN] deprecated eslint@8.57.1

2 participants