Conversation
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe website migrated from ESLint 8 legacy configuration to ESLint 9 flat configuration. The new configuration includes JavaScript, TypeScript, and Qwik presets, project-wide ignores, environment globals, TypeScript project-service parsing, JSX support, and project-specific rules. The package metadata adds the required ESLint packages, removes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the website workspace lint tooling to ESLint v9.39.5 and migrates configuration from legacy .eslintrc/.eslintignore to an ESLint flat config (eslint.config.js), aligning with ESLint v9’s recommended setup and addressing the deprecated eslint@8.57.1 warning in issue #174.
Changes:
- Upgraded
websitedevDependencies to ESLint^9.39.5and added supporting flat-config dependencies (@eslint/js,globals,typescript-eslint). - Replaced
website/.eslintrc.cjsandwebsite/.eslintignorewith a newwebsite/eslint.config.jsflat config. - Updated
website/tsconfig.jsonto include the new ESLint config file, and refreshedpnpm-lock.yaml.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/tsconfig.json | Updates TS project files list to reference eslint.config.js instead of the removed .eslintrc.cjs. |
| website/package.json | Bumps ESLint to v9 and adds flat-config-related devDependencies. |
| website/eslint.config.js | Introduces ESLint v9 flat configuration with global ignores, TS + Qwik presets, and local rule overrides. |
| website/.eslintrc.cjs | Removes legacy ESLint config (replaced by flat config). |
| website/.eslintignore | Removes legacy ignore file (replaced by flat config ignores). |
| pnpm-lock.yaml | Lockfile updates reflecting ESLint v9 and dependency changes. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
resolves: #174
Summary by CodeRabbit