Skip to content

Restore formatting and Windows asset-patch tests - #526

Merged
justinchuby merged 2 commits into
mainfrom
fix/inspect-test-format
Aug 21, 2026
Merged

Restore formatting and Windows asset-patch tests#526
justinchuby merged 2 commits into
mainfrom
fix/inspect-test-format

Conversation

@titaiwangms

@titaiwangms titaiwangms commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apply the repository Ruff formatter to two long calls added by Add component inspection API #378
  • write the asset-patch SHA fixture as exact UTF-8 bytes so Windows newline translation cannot change LF to CRLF before hashing
  • restore the all-files lint job and the four asset-patch tests failing across all Windows Python versions on main and dependent pull requests

Validation

  • 9 passed, 1 subtests passedsrc/mobius/upstream_patches/_patches_test.py
  • Ruff check and format passed for both changed test files
  • git diff --check

Only test formatting/fixture construction changes; runtime behavior is unchanged.

Restore all-files Ruff formatting after #378 so main and dependent pull requests pass lint.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e10674c1-6909-4b09-9f5a-d41b28c89d2d
@titaiwangms
titaiwangms requested review from a team and a lite review from Copilot August 20, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies Ruff formatting to long monkeypatch.setattr(...) calls in the component inspection tests, keeping the test logic unchanged and improving readability/consistency with the repo formatter.

Changes:

  • Split long monkeypatch.setattr calls into multi-line argument lists with trailing commas for Ruff formatting compliance.
  • No behavioral changes to the tests; only formatting adjustments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

🏗️ Architecture Diff

Comparing 66e9c5ef82dfc0

Model Sub-model Changes Status

No architecture changes detected.


Legend: ⚪ No change · 🔵 Minor (attrs/inits) · 🟡 Moderate (nodes added/removed) · 🔴 Major (interface changed)

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Performance Comparison

Comparing 66e9c5ef82dfc0

Model Metric Baseline Current Delta
bert (feature-extraction) model_size_bytes 359 KB 359 KB +0.0%
bert (feature-extraction) num_nodes 60 60 +0.0%
falcon model_size_bytes 364 KB 364 KB +0.0%
falcon num_nodes 66 66 +0.0%
gemma2 model_size_bytes 428 KB 428 KB +0.0%
gemma2 num_nodes 105 105 +0.0%
gpt2 model_size_bytes 388 KB 388 KB +0.0%
gpt2 num_nodes 54 54 +0.0%
llama model_size_bytes 425 KB 425 KB +0.0%
llama num_nodes 60 60 +0.0%
llama (static-cache) model_size_bytes 425 KB 425 KB +0.0%
llama (static-cache) num_nodes 56 56 +0.0%
mamba (ssm-text-generation) model_size_bytes 296 KB 296 KB +0.0%
mamba (ssm-text-generation) num_nodes 94 94 +0.0%
phi3 model_size_bytes 421 KB 421 KB +0.0%
phi3 num_nodes 58 58 +0.0%
phi3 (static-cache) model_size_bytes 421 KB 421 KB +0.0%
phi3 (static-cache) num_nodes 54 54 +0.0%
qwen2 model_size_bytes 425 KB 425 KB +0.0%
qwen2 num_nodes 60 60 +0.0%
qwen2 (static-cache) model_size_bytes 425 KB 425 KB +0.0%
qwen2 (static-cache) num_nodes 56 56 +0.0%
qwen3_5_moe (hybrid-text-generation) model_size_bytes 506 KB 506 KB +0.0%
qwen3_5_moe (hybrid-text-generation) num_nodes 264 264 +0.0%
qwen3_5_text (hybrid-text-generation) model_size_bytes 458 KB 458 KB +0.0%
qwen3_5_text (hybrid-text-generation) num_nodes 126 126 +0.0%
qwen3_5_vl (hybrid-qwen-vl) model_size_bytes 977 KB 977 KB +0.0%
qwen3_5_vl (hybrid-qwen-vl) num_nodes 428 428 +0.0%
t5 (seq2seq) model_size_bytes 836 KB 836 KB +0.0%
t5 (seq2seq) num_nodes 166 166 +0.0%
whisper (speech-to-text) model_size_bytes 1008 KB 1008 KB +0.0%
whisper (speech-to-text) num_nodes 128 128 +0.0%

No performance regressions.

Write the hashed chat-template fixture as exact UTF-8 bytes so Windows newline translation does not invalidate its expected SHA-256.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e10674c1-6909-4b09-9f5a-d41b28c89d2d
@titaiwangms titaiwangms changed the title Format component inspection tests Restore formatting and Windows asset-patch tests Aug 20, 2026
@justinchuby

Copy link
Copy Markdown
Member

thanks!

@justinchuby
justinchuby merged commit ce1926f into main Aug 21, 2026
22 of 23 checks passed
@justinchuby
justinchuby deleted the fix/inspect-test-format branch August 21, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants