Skip to content

chore(skills): move data-explorer to Drop - #414

Merged
vite-hub[bot] merged 1 commit into
mainfrom
chore/move-data-explorer-to-drop
Nov 12, 2026
Merged

vite-hub[bot] merged 1 commit into
mainfrom
chore/move-data-explorer-to-drop

Conversation

@onmax

@onmax onmax commented Nov 12, 2026

Copy link
Copy Markdown
Owner

data-explorer (#410) writes an HTML page from a report.json, not Comark. It doesn't use comark-charts either: its template draws with Vega-Lite and only used comark-ui on jsDelivr to load app.js and style.css. Its page ends up in Drop anyway, where a rebuild on new data becomes the next version at the same link.

The skill now lives in Drop (vite-hub/drop@ff069969), which serves it at /.well-known/skills/data-explorer/ and as the fallback for a page's template. This PR removes the skill, its docs page and its test from comark-ui, and the skills index and report point to Drop's. It has to merge before the v0.11.1 release (#408), so npm never ships the jsDelivr path that unfilled pages would depend on.

The release notes in #408 still list #410, since uppt builds them from commits. That line should go when the release is cut.

Checked: the comark-ui build, packages/ui/test/skills.test.ts and test/workspace.test.ts (417 passed), pnpm run lint:docs and vp fmt --check. I didn't run the full pnpm ready.

It writes an HTML page from report.json rather than Comark, and its page ends up in Drop. Drop serves it now (vite-hub/drop ff069969), so comark-ui drops the skill, its docs page and its test, and the skills index and report point to Drop's.
@pullfrog

pullfrog Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The workflow's Verify CLIProxy completion step failed, so Pullfrog never ran. That step runs before Pullfrog in this repo's workflow, so the fix is in the workflow or that step's own setup.

GitHub's error
Process completed with exit code 22.

View the step's logs →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-12T11:44:46.197874Z
We couldn’t complete this review. Comment @codex review to try again.
d6b937a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark-annotate

pnpm add https://pkg.pr.new/comark-annotate@414

comark-badge

pnpm add https://pkg.pr.new/comark-badge@414

comark-cards

pnpm add https://pkg.pr.new/comark-cards@414

comark-carousel

pnpm add https://pkg.pr.new/comark-carousel@414

comark-cast

pnpm add https://pkg.pr.new/comark-cast@414

comark-charts

pnpm add https://pkg.pr.new/comark-charts@414

comark-chat

pnpm add https://pkg.pr.new/comark-chat@414

comark-chips

pnpm add https://pkg.pr.new/comark-chips@414

comark-cjk

pnpm add https://pkg.pr.new/comark-cjk@414

comark-code

pnpm add https://pkg.pr.new/comark-code@414

comark-code-notes

pnpm add https://pkg.pr.new/comark-code-notes@414

comark-colors

pnpm add https://pkg.pr.new/comark-colors@414

comark-comments

pnpm add https://pkg.pr.new/comark-comments@414

comark-critic

pnpm add https://pkg.pr.new/comark-critic@414

comark-deflist

pnpm add https://pkg.pr.new/comark-deflist@414

comark-details

pnpm add https://pkg.pr.new/comark-details@414

comark-diagrams

pnpm add https://pkg.pr.new/comark-diagrams@414

comark-diff

pnpm add https://pkg.pr.new/comark-diff@414

comark-embed

pnpm add https://pkg.pr.new/comark-embed@414

comark-fields

pnpm add https://pkg.pr.new/comark-fields@414

comark-figure

pnpm add https://pkg.pr.new/comark-figure@414

comark-file-tree

pnpm add https://pkg.pr.new/comark-file-tree@414

comark-footnotes

pnpm add https://pkg.pr.new/comark-footnotes@414

comark-github

pnpm add https://pkg.pr.new/comark-github@414

comark-icon

pnpm add https://pkg.pr.new/comark-icon@414

comark-include

pnpm add https://pkg.pr.new/comark-include@414

comark-keys

pnpm add https://pkg.pr.new/comark-keys@414

comark-links

pnpm add https://pkg.pr.new/comark-links@414

comark-linter

pnpm add https://pkg.pr.new/comark-linter@414

comark-magic-move

pnpm add https://pkg.pr.new/comark-magic-move@414

comark-mark

pnpm add https://pkg.pr.new/comark-mark@414

markdown-it-to-comark

pnpm add https://pkg.pr.new/markdown-it-to-comark@414

marked-to-comark

pnpm add https://pkg.pr.new/marked-to-comark@414

comark-mathml

pnpm add https://pkg.pr.new/comark-mathml@414

comark-media

pnpm add https://pkg.pr.new/comark-media@414

comark-metrics

pnpm add https://pkg.pr.new/comark-metrics@414

migrate-to-comark

pnpm add https://pkg.pr.new/migrate-to-comark@414

comark-outline

pnpm add https://pkg.pr.new/comark-outline@414

comark-properties

pnpm add https://pkg.pr.new/comark-properties@414

comark-qr

pnpm add https://pkg.pr.new/comark-qr@414

comark-quiz

pnpm add https://pkg.pr.new/comark-quiz@414

comark-reading-time

pnpm add https://pkg.pr.new/comark-reading-time@414

remark-to-comark

pnpm add https://pkg.pr.new/remark-to-comark@414

comark-sources

pnpm add https://pkg.pr.new/comark-sources@414

comark-steps

pnpm add https://pkg.pr.new/comark-steps@414

comark-table

pnpm add https://pkg.pr.new/comark-table@414

comark-tabs

pnpm add https://pkg.pr.new/comark-tabs@414

comark-tests

pnpm add https://pkg.pr.new/comark-tests@414

comark-time

pnpm add https://pkg.pr.new/comark-time@414

comark-ui

pnpm add https://pkg.pr.new/comark-ui@414

comark-xref

pnpm add https://pkg.pr.new/comark-xref@414

comark-zoom

pnpm add https://pkg.pr.new/comark-zoom@414

commit: d6b937a

@vite-hub

vite-hub Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

@vite-hub
vite-hub Bot merged commit a4ad2ee into main Nov 12, 2026
5 of 6 checks passed
@vite-hub
vite-hub Bot deleted the chore/move-data-explorer-to-drop branch November 12, 2026 13:11
This was referenced Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant