Repository navigation
feat(docs): share playground links through @vite-hub/ui/playground - #393
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 finding remains.
Reviewed changes across the playground, generated docs links, component gallery sharing, link validation, dependency pin, and updated package-page links.
- Shared playground codec — Replaced the private deflate/base64 state with
@vite-hub/ui/playgroundfiles, hashes, URLs, and preset templates. - Playground restoration — Loads shared Markdown, config, theme, and preset identity while preserving the existing untouched-preset behavior and reset flow.
- Gallery sharing — Encodes changed cells and added-copy metadata through the shared codec in the gallery query string and replays them on load.
- Generated links and validation — Builds shared links for docs examples, the landing studio, preset cards, and gallery actions, then decodes and parses them during built-doc validation.
- Dependency and docs migration — Pins the ViteHub UI build that exports the codec and migrates the remaining package-page preset links to
#code=.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request 5ab07dd2-e62f-4fe9-9687-be0fa6f9fa32. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. Session Pushed e209869, resolving conflicts with main’s PlaygroundRender migration. Frozen installation, focused lint, formatting, and codec round trips passed. Package builds hit pnpm’s automatic reinstall failure; docs-scoped tests found no files. The clean final tree matches main. Pullfrog: no valid findings. Awaiting hosted CI. |
|
Your Custom account has hit its usage limit. Raise the limit with the provider, or re-trigger once it resets. Custom's responseConnect a provider → · Pick another model →
|
|
No configured credential can serve this run. Your ChatGPT subscription has hit its usage limit, which resets at 2026-11-13 17:11 UTC. Re-trigger after it resets, or add an API key for this provider, which Pullfrog falls back to automatically. The providers' responses
|
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 finding remains.
Reviewed changes since the prior review at 7297ff0, focusing on the playground codec's reconciliation with the shared design-system build and canonical URLs.
- Isolated the playground codec — Routed the browser playground, gallery, build-time links, and link validator through
@vite-hub/ui-playground/playground, retaining codec build0fe50ee. - Preserved the shared design system — Kept the main UI and Console dependencies on
4cd1f4cd, added the separate catalog/lockfile alias, and documented when to remove it. - Reconciled canonical links — Preserved
/play#code=…links across the merges frommain, including the studio, package pages, and link-checker fixtures.
Validation passed: frozen dependency installation, workspace build and typecheck, all 44 link tests, playground asset generation, browser-target bundling, and round trips for all 132 presets and their standalone example links. Full Nuxt generation and browser interaction tests were not repeated.
gpt-6.1-sol(xhigh) ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 finding remains.
Reviewed changes since the prior substantive review at d31ec7e, focusing on the dependency reconciliation in ee37915; the intervening base-only merges did not change the PR's behavior.
- Reconciled ViteHub dependencies — Preserved main's
869db474packages and overrides while retaining the isolated0fe50eeplayground codec alias. - Regenerated the codec dependency graph — Updated the alias's lockfile snapshot against the current workspace without changing playground or gallery application code.
Validation passed: frozen installation, workspace build and typecheck, all 44 link tests, browser-target playground/gallery bundling, and codec round trips for standalone links, presets, edited presets, config/theme state, and gallery copies. Full Nuxt generation and browser interaction tests were not repeated.
gpt-6.1-sol(xhigh) ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 finding remains.
Reviewed changes since the prior review at ee37915, scoped to the playground codec's dependency reconciliation in e7659e4 rather than unrelated changes merged from main.
- Reconciled ViteHub dependencies — Preserved current main's
bc43707packages and overrides while retaining the isolated0fe50eeplayground codec alias. - Regenerated the codec dependency snapshot — Resolved the alias's comments and web-container dependencies against the current build without changing playground or gallery application code.
Validation passed: frozen installation, workspace build and typecheck, all 44 link tests, browser-target playground/gallery bundling, 20 cross-version codec round trips, and decoding of all six static preset links. Both browser bundles include only the isolated codec, not the older UI runtime. Full Nuxt generation and browser interaction tests were not repeated.
gpt-6.1-sol(xhigh) ｜ 𝕏
comark-ui had its own playground link format in three places:
docs/play-link.ts, an inline copy indocs/studio.ts, and the gallery'seditparam. vitehub.dev and glosa each had another one. A link from one site could not open in the other.This switches all of them to
@vite-hub/ui/playgroundfrom vite-hub/vitehub#3744. The playground state is now files:content.md, plusconfig.jsonandtheme.jsononly when they are not the defaults. Each preset is a template, so an unedited preset link is about 30 characters (/play#code=q1YqUbJSKklMKtYFEUq1AA), and an edited preset keeps its Reset button when you reopen the link. Docs examples and the studio write template-less links with onlycontent.md. Gallery edits go in?code=with the same codec: one<id>.mdper changed cell andadded.jsonfor copies.Old
#md=,#preset=,#config=,#theme=and?edit=links no longer open. An old#md=link now shows the first preset. I updated the six/play/#preset=links in the package pages.pack,unpack, and the studio copy are gone.playablestays indocs/play-link.ts.docs/play-links.tsnow decodes each#code=link with the presets as templates and parses it with the link's config.@vite-hub/uiis pinned to the pkg.pr.new build of #3744 (0fe50ee). The other@vite-hub/*packages stay on the hosted Console stack (2707919), because that stack is not onmainand #3744 is. The lockfile changes only by the@vite-hub/uientry. Once vite-hub/vitehub#3744 merges, move the pin to a release ormain.Checks:
test/links.test.ts: 13 passed. With packages built, all threelinks.test.tsfiles: 45 passed.pnpm docs:build: passed, and it checked the links of 413 pages.node docs/play-links.ts: opened 472 playground states from 493 links, with no problems.pnpm typecheckandpnpm --filter comark-ui-docs typecheck: passed.vp lintandvp fmt --checkon the changed files: clean.pnpm install --frozen-lockfile: passed.#code=link shows its Markdown, a preset link shows the preset,#code=garbageshows "The link's Markdown is cut off or changed.", an edit rewrites the hash and reopens with Reset visible, and/play/gallery?code=…applies an edited cell and adds a copy. No page errors.I did not run
pnpm readyor the e2e suite, and I did not check the deployed site.