Skip to content

chore: add Liva citizenIDs to ids csv - #256

Open
K-Beicher wants to merge 2 commits into
mainfrom
chore/add-liva-ids-to-list
Open

K-Beicher wants to merge 2 commits into
mainfrom
chore/add-liva-ids-to-list

Conversation

@K-Beicher

Copy link
Copy Markdown
Contributor

Description

Got a list of IDs from Liva with a corresponding ID in our system and have added them to the ids.csv

I've just added liva_ to the field name, as citizenid is what Liva refers to their user IDs as.

Closes #

Needs a quick review.

Checklist

  • Ran just run-all
  • (When relevant) Ran just build-package

@K-Beicher
K-Beicher requested a review from a team as a code owner October 15, 2026 10:53
@K-Beicher K-Beicher self-assigned this Oct 15, 2026
@K-Beicher K-Beicher moved this from Todo to In Review in Data development Oct 15, 2026
@K-Beicher
K-Beicher requested a review from lwjohnst86 October 15, 2026 10:54

@signekb signekb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion ✏️

Comment thread raw/ids.csv
022;22;i1115;22-4
023;23;i1102;23-4
024;24;i1113;24-4
participant_id;record_id_s;id_number_pre;myfood24_id;liva_citizenid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
participant_id;record_id_s;id_number_pre;myfood24_id;liva_citizenid
participant_id;record_id_s;id_number_pre;myfood24_id;liva_citizen_id

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to keep to the original from the source. In my eyes this is just good data practice, as this is meant to be the table that will help identifying the link IDs from a variety of systems.

Comment thread raw/ids.csv
022;22;i1115;22-4
023;23;i1102;23-4
024;24;i1113;24-4
participant_id;record_id_s;id_number_pre;myfood24_id;liva_citizenid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe even change id_number_pre to pre_number_id, so all ID's end with _id? If you agree, you can add another PR with that since that's unrelated to adding ID's from Liva 😊

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, the first couple of IDs comes directly from REDCap, actually, maybe we should prefix them with exactly that...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During processing we can rename them to all end in _id. And in the end all of these ids will be consolidated into a single participant_id, regardless of data source.

@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Data development Oct 15, 2026
@lwjohnst86 lwjohnst86 moved this from In Progress to Todo in Data development Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants