Replace YT6801 DKMS driver with upstream support - #9682
Draft
AFOliveira wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The migration cannot recover an unbound device when rerun after the vendor module has already been unloaded.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Replaces the vulnerable YT6801 DKMS driver with upstream kernel support.
Changes:
- Removes
yt6801-dkmsfrom installation. - Adds hardware cleanup and migration logic.
- Adds focused shell regression coverage.
File summaries
| File | Description |
|---|---|
install/omarchy-other.packages |
Removes the DKMS package. |
install/hardware/fix-yt6801-ethernet-adapter.sh |
Removes legacy drivers without loading modules. |
migrations/1788279117.sh |
Performs the live driver cutover. |
test/shell.d/yt6801-driver-test.sh |
Tests installation and migration behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+27
to
+33
| if lsmod | awk '$1 == "yt6801" { found = 1 } END { exit !found }'; then | ||
| sudo modprobe -r yt6801 | ||
|
|
||
| for device in "${yt6801_devices[@]}"; do | ||
| printf '%s\n' "$device" | sudo tee /sys/bus/pci/drivers_probe >/dev/null | ||
| done | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
yt6801-dkmspackage for Motorcomm1f0a:6801adapters.dwmac-motorcommdriver, removes the vendor package, reprobes the device, and verifies the final binding.Why
The vendor driver exposes a user-reachable private ioctl command interface with unsafe buffer handling and privileged hardware controls. Current Omarchy kernels already ship an in-tree driver with the exact YT6801 PCI alias, so the safest default is to remove the external driver entirely.
Verification
bash test/shell.d/yt6801-driver-test.shbash -n install/hardware/fix-yt6801-ethernet-adapter.sh migrations/1788279117.sh test/shell.d/yt6801-driver-test.shgit diff --checkdwmac-motorcommmodule has the exact1f0a:6801alias, is in-tree, and is signed.Deployment
The migration fails clearly and remains retryable when the booted kernel does not yet contain the replacement alias. A reboot into the latest Omarchy kernel is then required before rerunning migration.